[ANE-2458] Enable path dependency analysis by default#1697
Draft
[ANE-2458] Enable path dependency analysis by default#1697
Conversation
Path dependency license scanning is now enabled by default for supported ecosystems (Go, PDM, Cargo). The --experimental-analyze-path-dependencies flag is deprecated and is preserved as a hidden no-op that emits a deprecation warning. Users who want the prior behavior can opt out with the new --disable-path-dependency-scans flag. The previous "nudge" that logged a note when unresolved path dependencies were detected is no longer needed and has been removed.
Member
Author
Scan: analyzers that find path deps that don't get uploadedResearch only — no code changes. Two groups below. Emit
|
Gems declared in a `PATH` section of `Gemfile.lock` were previously reported as `GemType` deps with the local path only in `dependencyLocations`. They never reached the path-dependency scan/upload pipeline, so their license data was never captured even when path-dependency scanning was enabled. Treat them as path dependencies: set `dependencyType = UnresolvedPathType` and use the PATH section's `remote` value (the local filesystem path) as the dependency name, matching the convention Cargo, Go, PDM, and uv already use. The path-dependency enrichment step then resolves, hashes, license-scans, and uploads the gem source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Flips the default for path dependency license scanning from off to on. The legacy
--experimental-analyze-path-dependenciesflag is kept as a hidden no-op that emits a deprecation warning. A new--disable-path-dependency-scansflag is introduced for opt-out.Acceptance criteria
fossa analyzeon a project containing path dependencies in a supported ecosystem (Goreplacedirectives, PDMpath = ..., Cargopath = ...) now triggers a CLI license scan and upload without any extra flag.fossa analyze --disable-path-dependency-scansrestores the previous default behavior (skip license scanning of path deps).fossa analyze --experimental-analyze-path-dependenciesprints a deprecation notice but does not change behavior (path deps are scanned either way).Testing plan
cabal build spectrometer— succeeds.cabal build unit-tests— succeeds.fossa analyze --helpto confirm--disable-path-dependency-scansis listed and--experimental-analyze-path-dependenciesis hidden.fossa analyzeon a Go project with areplacedirective pointing at a local path and confirm the path dep is license-scanned without passing any flag.fossa analyze --disable-path-dependency-scanson the same project and confirm no path dep scan occurs.fossa analyze --experimental-analyze-path-dependencieson the same project and confirm a deprecation warning is printed.Risks
orgSupportsPathDependencyScansenabled will start uploading path dependency license data without explicitly opting in. The code path already gates onorgSupportsPathDependencyScans, so orgs without the feature are unaffected.Metrics
--disable-path-dependency-scanspost-release would indicate friction; if we see widespread opt-out, we should revisit.References
Checklist
App.Fossa.PathDependencySpeccontinues to cover the core enrichment logic. The CLI-flag flip is exercised indirectly viafixtureStrategyConfig.resolvePathDependencies = True, which now matches the new default.docs/.docs/README.msand gave consideration to how discoverable or not my documentation is.Changelog.md..fossa.ymlorfossa-deps.{json.yml}, I updateddocs/references/files/*.schema.json...docs/references/subcommands/<subcommand>.md.