fix: resolve moved visual node imports#261
Open
prashanthnimmagadda wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes local dependency resolution for imported visual
.flydefiles that live in a different folder from the parent flow.When a visual node file is imported from another directory, any local file imports inside that visual node were resolved relative to the parent flow path. This caused nested dependencies to break after moving the imported flow file into its own folder.
This change rebases nested file-source paths for imported visual nodes so their local dependencies continue resolving from the visual node file’s own directory.
Fixes #112
/claim #112
Test plan
a.flydeimportsmoved/b.flyde, andb.flydeimportsAdd.flyde.jsfrom its own folder.All commands passed.