Accommodate Emacs 31 earlier tab-bar-tab-post-open-functions#65
Open
shipmints wants to merge 1 commit intoflorommel:mainfrom
Open
Accommodate Emacs 31 earlier tab-bar-tab-post-open-functions#65shipmints wants to merge 1 commit intoflorommel:mainfrom
shipmints wants to merge 1 commit intoflorommel:mainfrom
Conversation
See florommel#64 Starting in Emacs 31, 'tab-bar-tab-post-open-functions' are called for the initial tab on a frame, and prior to 'after-make-frame-functions' when the 'tab-bar' is being set up during frame initialization. We ensure that 'bufferlo--tab-include-exclude-buffers' is skipped until 'bufferlo--include-exclude-buffers' is called after the frame is created, and our curated 'buffer-list' parameter is initialized for the frame/tab. Therein after it is safe to call 'bufferlo--tab-include-exclude-buffers' for each subsequent new tab. This strategy is safe to use on Emacs < 31. * bufferlo.el (bufferlo-mode): Add and remove 'bufferlo--tab-include-exclude-buffers-inhibit' on 'before-make-frame-hook'. Minor rearrangement to make more logical sense given call flow. (bufferlo--include-exclude-buffers): Uninhibit the block. (bufferlo--tab-include-exclude-buffers-inhibit): New defvar. (bufferlo--tab-include-exclude-buffers-inhibit): New defun to manage the defvar. (bufferlo--tab-include-exclude-buffers): Consult 'bufferlo--tab-include-exclude-buffers-inhibit'.
shipmints
force-pushed
the
shipmints-emacs31-early-tab-bar-tab-post-open-functions
branch
from
e70a91c to
fa442c2
Compare
Collaborator
Author
|
Rebased and documentation updated to explain the strategy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #64
(bufferlo--include-exclude-buffers): Uninhibit the block. (bufferlo--tab-include-exclude-buffers-inhibit): New defvar. (bufferlo--tab-include-exclude-buffers-inhibit): New defun to manage the defvar.
(bufferlo--tab-include-exclude-buffers): Consult
'bufferlo--tab-include-exclude-buffers-inhibit'.