Add Sensing action_control block to bind keys for movement/actions#344
Open
tracygardner wants to merge 5 commits intomainfrom
Open
Add Sensing action_control block to bind keys for movement/actions#344tracygardner wants to merge 5 commits intomainfrom
tracygardner wants to merge 5 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
action_control(blocks/sensing.js) that shows an action dropdown plus a grid key picker and appears next toaction_pressedin the Sensing toolbox (toolbox.js, locale/en.js).action_controlemitssetActionKey(action, key)at generation time (generators/generators.js).api/sensing.js:setActionKey(action, key)andgetActionKeys(action), and updatedactionPressed(action)to consult custom keys plus defaults; updatedwhenActionEventto usegetActionKeysso events and booleans stay in sync.flock.actionKeyMapand initialization/reset hooks inflock.js, and added translation strings and tooltip text for the new block (locale/en.js).Testing
npm run buildcompleted successfully on the branch (bundle built).npm run lintfailed due to pre-existing lint issues inflock.jsthat are unrelated to this change (reported by the linter).npm run test:apifailed in this environment because Playwright’s browser binaries are not installed (environment limitation), not because of the change.action_controlblock in Sensing was produced atartifacts/action-control-sensing.png.Codex Task