Add back factory function to fix ReactFiberWorkLoop allocation errors#46
Merged
Add back factory function to fix ReactFiberWorkLoop allocation errors#46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
I was wrong in thinking that a
do..endblock would be functionally equivalent. Tests passed, but in practice ReactFiberWorkLoop will exceed the 200 allocation limit and start erroringSolution
To fix this, I've added back the module factory pattern. It's really unfortunate we need two anonymous functions per require, but I think this will serve us well for now. In the future I'm still considering going back to a setfenv approach