feat(phase2): add @attr declarations for vendor freight, place operational, and service-area scoping fields#48
Open
TLemmAI wants to merge 2 commits intofleetbase:mainfrom
Open
Conversation
…ional, and service-area scoping fields
…o feat/multi-tenant-phase2-attrs
Author
|
#48 merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds missing Ember Data
@attrdeclarations on three existing models to support Phase 2 of the upstream fleetbase/core-api multi-tenant / settings work.Without these, the Ember frontend in fleetbase/fleetops ignores assignments to the new fields, omits them from serialized payloads on save, and drops them from deserialized responses on load — so freshly-added UI form fields don't round-trip through Ember Data.
Vendor (9 new attrs — freight / carrier fields)
scac_code(string)mc_number(string)dot_number(string)insurance_expiry(date)insurance_amount(number)payment_terms_days(number)default_payment_method(string)carrier_type(string)is_preferred(boolean)Place (5 new attrs — operational / contact fields)
location_type(string)appointment_required(boolean)contact_name(string)contact_phone(string)contact_email(string)ServiceArea (2 new attrs — non-polygon geographic scoping)
states_list(raw — array of state codes)zip_ranges(raw — array of{start, end}range objects)Backend context
The backend columns were added in corresponding migrations in the upstream
fleetopsserver (carrier freight, place operational, service-area state/zip scoping). This change is additive; existing attrs are untouched.Test plan
metafor operating_hours / dock_info / special_instructionsstates_list+zip_rangeswhile leaving polygonborderuntouched