New buddy allocator tests + bug fixes#26
Merged
Akshay-Srivatsan merged 16 commits intomainfrom Apr 20, 2026
Merged
Conversation
shah-niam
changed the title
Contributor
|
Could you fix the warnings that popped up and rebase this onto Greg's changes from #28? Also I see a few places this PR comments out lines of code; could you either delete those lines (if they're not needed) or leave a comment explaining why they're commented out? |
added 5 commits
April 10, 2026 15:35
…nding support for running via 'cargo test' and a detailed run through to ensure testing is thorough and accurate as well as fixing runtime error. Full coverage of all data types
…led. Want confirmation that failing tests are accurately testing expected behavior before fixing.
… big were being accepted and another where many allocate functions were not releasing lock if they ran out of memory mid-function
Contributor
Author
|
Everything passed, warnings fixed (annotations only there because locally i am on rust 1.96; they reference pieces already present in main), commented code deleted edit: still one thing to fix; in progress |
Contributor
Author
|
Everything fixed, can be merged |
Akshay-Srivatsan
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added many tests for buddy allocator and a few tests for data types in kernel + fixed bugs caught by tests
Testing file in kernel + buddy.rs are relevant for these changes