chore: document files subsystem in CLAUDE.md + drop dead pathlib import#138
Open
rdwj wants to merge 1 commit into
Open
chore: document files subsystem in CLAUDE.md + drop dead pathlib import#138rdwj wants to merge 1 commit into
rdwj wants to merge 1 commit into
Conversation
Two small session-close cleanups: - CLAUDE.md: extend the server-module-structure decision block to list files.py / bytes_store.py / parser.py / scanner.py / feedback.py / pricing.py / budget.py / http.py. Add a new decision block for the file upload subsystem covering FileStore + BytesStore split per ADR-0001, parser dispatch tiers, optional [files] / [s3] extras, endpoints, and pointers to ADR-0002 + tracking issue #137 for the chunking work. - tests/test_files_endpoint.py: drop the duplicate ``from pathlib import Path`` at line 259. Path is already imported at line 242 within the same test class for the only Path usage. Caught by ruff during /session-close. No behavior changes. Tests stay green (970 passed); ruff now clean. Assisted-by: Claude Code (Opus 4.7 1M)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small session-close cleanups.
CLAUDE.md
Extend the server-module-structure decision block — it was listing
app.py/models.py/sessions.py/tracing.py/collector.py/metrics.py/otel.py/propagation.py/sqlite.pybut missing the file-upload subsystem files added in 0.16.0–0.17.0 (files.py,bytes_store.py,parser.py,scanner.py) plus a few stragglers (feedback.py,pricing.py,budget.py,http.py).Add a new File upload subsystem decision block covering:
SqliteFileStore/PostgresFileStorewith anyBytesStore.[files]extra).[files]~5–6 GB,[s3]~30 MB).file_idschat-completion behavior.FilesConfig.sqlite_pathco-locating metadata DB on the bytes PVC.tests/test_files_endpoint.py
Drop the duplicate
from pathlib import Pathat line 259.Pathis already imported at line 242 within the same test class for the onlyPathusage in that scope. Caught byruffduring/session-close.Verification
pytest: 970 unit tests pass.ruff check src tests: clean.Test plan