Merged
Conversation
The external sync workflow in fingerprint-pro-server-api-openapi invokes this script with only setup-python in the environment, so the ruff module is not preinstalled and `python3 -m ruff format` fails with "No module named ruff". Install ruff (pinned to 0.15.0 to match pyproject.toml's dev dep) inside generate.sh so callers don't need to know to install it first. Failure: https://github.com/fingerprintjs/fingerprint-pro-server-api-openapi/actions/runs/24790520856
JuroUhlar
requested review from
TheUnderScorer,
erayaydin and
ilfa
as code owners
Contributor
pnpm exec changesetto create a changeset. |
Contributor
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
erayaydin
approved these changes
Apr 23, 2026
Member
erayaydin
left a comment
erayaydin
left a comment
There was a problem hiding this comment.
LGTM. If the "poetry-only" migration takes too long, we could run ruff with docker like it was done in the PHP SDK (w/ php-cs-fixer), or we could read the ruff version from pyproject in the generate.sh file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The external sync workflow in
fingerprint-pro-server-api-openapiinvokesbash ./generate.shwith onlyactions/setup-pythonin the environment, soruffis not preinstalled and the script fails withNo module named ruff. This makesgenerate.shself-contained by installing ruff itself, so callers don't need to know to install it first.Pinned to
0.15.0to match the dev-dep inpyproject.toml.Failure
https://github.com/fingerprintjs/fingerprint-pro-server-api-openapi/actions/runs/24790520856 — Python job.
Test plan
bash ./generate.shend-to-end in a clean venv (docker + pip install + ruff format + ruff check) locally