Pull Request: Fixes and Enhancements for ESP32 HTTPS Certificate Generation#189
Open
cturqueti wants to merge 1 commit intofhessel:masterfrom
Open
Pull Request: Fixes and Enhancements for ESP32 HTTPS Certificate Generation#189cturqueti wants to merge 1 commit intofhessel:masterfrom
cturqueti wants to merge 1 commit intofhessel:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script 'create_cert.sh' had critical issues preventing reliable certificate generation:
Changes Made:
1. CA Configuration Fixes
2. Certificate Signing Improvements
3. Cross-Platform Compatibility
4. Output File Generation
Testing Performed:
Verification Command:
openssl verify -CAfile exampleca.crt example.crt
Impact:
Notes for Reviewers: