[MNT] add support for python 3.14#892
Open
ankitlade12 wants to merge 5 commits intofeature-engine:mainfrom
Open
[MNT] add support for python 3.14#892ankitlade12 wants to merge 5 commits intofeature-engine:mainfrom
ankitlade12 wants to merge 5 commits intofeature-engine:mainfrom
Conversation
9ca5c57 to
6139799
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #892 +/- ##
=======================================
Coverage 98.22% 98.22%
=======================================
Files 113 113
Lines 4842 4842
Branches 768 768
=======================================
Hits 4756 4756
Misses 55 55
Partials 31 31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Thank you @ankitlade12 This is great. I assume it is ready to merge, shall I go ahead? I normally update the what's new file shortly before launching the new version of feature-engine, and then I let everyone who has contributed know, so they can check it and once they are happy, we launch. So I removed it from here. Thanks again! |
Contributor
Author
|
Thank you @solegalli! Yes, please go ahead and merge. I understand about the what's new file—thanks for handling that. Happy to see this moving forward! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[MNT] add support for python 3.14 (#890)
Description
This PR adds official support for Python 3.14 to
feature_engine. It updates the test matrix in both tox.ini and CircleCI to ensure the library remains stable and compatible with the latest Python release.Changes
py314toenvlistand created a corresponding[testenv:py314]section in tox.ini.test_feature_engine_py314job to .circleci/config.yml and integrated it into thetest-allandpackage_and_upload_to_pypiworkflows.@ankitlade12to the project contributors list.Verification Results
I have verified these changes by running the full unit test suite (1945 tests) on a Python 3.14.0 environment. All tests passed successfully.
I also double-checked both configuration files to ensures that support for older Python versions (3.9 - 3.13) was not affected.