Skip to content

chore: drop dependency to proc-macro-error2#12

Merged
tisonkun merged 2 commits into
mainfrom
drop-proc-macro-error2
Jun 8, 2026
Merged

chore: drop dependency to proc-macro-error2#12
tisonkun merged 2 commits into
mainfrom
drop-proc-macro-error2

Conversation

@tisonkun

@tisonkun tisonkun commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: tison <wander4096@gmail.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the proc-macro-error2 dependency from the stacksafe-macro proc-macro crate by switching to syn::Result/syn::Error for error reporting, and updates the workspace dependency set accordingly.

Changes:

  • Replace proc-macro-error2 abort-based error handling with syn::Error propagation and into_compile_error() emission.
  • Introduce an internal stacksafe_impl returning syn::Result<TokenStream> and adapt parsing to syn::parse2 / Parser::parse2.
  • Update workspace dependency declarations and lockfile to drop proc-macro-error2 and bump related crate versions.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
stacksafe-macro/src/lib.rs Reworks macro entrypoint and error handling to remove proc-macro-error2 usage.
stacksafe-macro/Cargo.toml Drops proc-macro-error2, adds direct proc-macro2 dependency.
Cargo.toml Updates workspace dependency list to remove proc-macro-error2 and pin proc-macro2 and other crates.
Cargo.lock Reflects dependency graph changes: removes proc-macro-error2 packages and updates resolved versions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun force-pushed the drop-proc-macro-error2 branch from c9447fa to e7d3ea4 Compare June 8, 2026 12:22
@tisonkun tisonkun merged commit dfe5a65 into main Jun 8, 2026
11 checks passed
@tisonkun tisonkun deleted the drop-proc-macro-error2 branch June 8, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants