fix(waitset): deregister cancelled broadcast receivers#116
Draft
orthur2 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows the discussion in #115.
WaitSet previously identified registrations with bare slab indices. After wake_all drained the slab, a new waiter could reuse an index while an old future still retained it. This PR changes the registration identity to WaiterId { index, generation } and checks both values before updating or removing a waiter.
WaitSet now provides remove_waker for removing one registration and take_wakers for draining registrations before waking them outside the lock.
Cancellation cleanup is limited to broadcast::overflow::Recv. Ready paths clear the waiter id, so normally completed receive futures do not take the WaitSet lock from Drop. A pending receive removes its registration when it is cancelled.
Latch, Once, and WaitGroup keep their previous cancellation behavior. Barrier::wait also remains not cancel safe, matching tokio::sync::Barrier.