feat: Add KeyedFairSemaphore#114
Open
tisonkun wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a new synchronization primitive, mea::keyed_fair_semaphore::KeyedFairSemaphore, to bound global concurrency while distributing permits fairly across independent “keys” (e.g., tenants/partitions) based on lowest in-flight counts with FIFO tie-breaking.
Changes:
- Added the
keyed_fair_semaphoremodule implementingKeyedFairSemaphoreplus borrowed/owned permit types. - Added a dedicated test suite covering fairness behavior, FIFO within a key, cancellation, and capacity stress.
- Updated crate docs/README to list and link the new primitive, and added Send/Sync/Unpin assertions in
lib.rstests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| README.md | Documents the new KeyedFairSemaphore and links to its docs.rs page. |
| mea/src/lib.rs | Exposes the new module and adds trait assertions for the new types. |
| mea/src/keyed_fair_semaphore/mod.rs | Implements the keyed fair semaphore, permits, and scheduling logic. |
| mea/src/keyed_fair_semaphore/tests.rs | Adds unit/stress tests for fairness, cancellation, and capacity invariants. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+370
to
+382
| fn release(&mut self, key: &Arc<K>) { | ||
| let Some(in_flight) = self.in_flight_by_key.get_mut(key) else { | ||
| return; | ||
| }; | ||
|
|
||
| *in_flight -= 1; | ||
| if *in_flight == 0 { | ||
| self.in_flight_by_key.remove(key); | ||
| } | ||
|
|
||
| self.available_permits += 1; | ||
| debug_assert!(self.available_permits <= self.total_permits); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification