consolidate gopsutil v1/v3 -> v4 (#623)#623
Closed
podtserkovskiy wants to merge 1 commit into
Closed
Conversation
podtserkovskiy
requested review from
CrimsonK1ng,
RoboticPrism,
d0n601 and
d3sch41n
as code owners
|
@podtserkovskiy has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108080810. |
Summary: Migrates 21 fbcode files from gopsutil v1 or v3 import paths to v4. Beyond the import-only swap planned, two v4 API changes required caller updates: disk.PartitionStat.Opts is now []string (was comma-separated string), and mem.VirtualMemoryStat renamed SReclaimable/SUnreclaim to Sreclaimable/Sunreclaim. 6 files remain on v1 paths: host/load subpackages and disk.SectorSize are not available in the fbcode v4 vendor tree. Reviewed By: siutsin Differential Revision: D108080810
meta-codesync
Bot
changed the title
podtserkovskiy
force-pushed
the
export-D108080810
branch
from
ecc70fa to
67a78d0
Compare
|
This pull request has been merged in e5e67de. |
meta-codesync Bot
pushed a commit
to facebook/time
that referenced
this pull request
Jun 10, 2026
Summary: X-link: facebookincubator/TTPForge#623 Migrates 21 fbcode files from gopsutil v1 or v3 import paths to v4. Beyond the import-only swap planned, two v4 API changes required caller updates: disk.PartitionStat.Opts is now []string (was comma-separated string), and mem.VirtualMemoryStat renamed SReclaimable/SUnreclaim to Sreclaimable/Sunreclaim. 6 files remain on v1 paths: host/load subpackages and disk.SectorSize are not available in the fbcode v4 vendor tree. Reviewed By: siutsin Differential Revision: D108080810 fbshipit-source-id: 8008e03fcee1602639be40a24a21f9c33b10633f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Migrates 21 fbcode files from gopsutil v1 or v3 import paths to v4. Beyond
the import-only swap planned, two v4 API changes required caller updates:
disk.PartitionStat.Opts is now []string (was comma-separated string), and
mem.VirtualMemoryStat renamed SReclaimable/SUnreclaim to Sreclaimable/Sunreclaim.
6 files remain on v1 paths: host/load subpackages and disk.SectorSize are
not available in the fbcode v4 vendor tree.
Reviewed By: siutsin
Differential Revision: D108080810