bump go version to 1.24#513
Closed
ESoapW wants to merge 1 commit intofacebook:mainfrom
Closed
Conversation
Summary: Unbreak GH lint check, which fails on D100332220 because it uses `strings.SplitSeq` (Go 1.24+) but the github mirror was pinned to 1.23. Going to 1.24 (not 1.26 to match internal) because the github toolchain ecosystem isn't there yet — golangci-lint v1.64.8 was built with Go 1.24 and Fedora packit ships Go 1.25.9, so a 1.26 bump breaks both. 1.24 is the minimum to allow `strings.SplitSeq` while keeping downstream consumers happy. Also pre-allocates two slices in sa53fw/detect/detect.go that GH `prealloc` lint surfaced once it could get past the typecheck failure (these warnings are silent under internal lint because Meta's arc lint config doesn't enable prealloc). Differential Revision: D101811003
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@ESoapW has exported this pull request. If you are a Meta employee, you can view the originating Diff in D101811003. |
Contributor
Author
|
Test succeeded and commit has been merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Unbreak GH lint check, which fails on D100332220 because it uses
strings.SplitSeq(Go 1.24+) but the github mirror was pinned to 1.23.Going to 1.24 (not 1.26 to match internal) because the github toolchain ecosystem isn't there yet — golangci-lint v1.64.8 was built with Go 1.24 and Fedora packit ships Go 1.25.9, so a 1.26 bump breaks both. 1.24 is the minimum to allow
strings.SplitSeqwhile keeping downstream consumers happy.Also pre-allocates two slices in sa53fw/detect/detect.go that GH
prealloclint surfaced once it could get past the typecheck failure (these warnings are silent under internal lint because Meta's arc lint config doesn't enable prealloc).Differential Revision: D101811003