Conversation
froydnj
approved these changes
Mar 27, 2026
Owner
|
yes, the rationale for this was getting the ruby build in, which github did
not do, we can remove this now
…On Fri, 27 Mar 2026 at 05:05, Nathan Froyd ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#852?email_source=notifications&email_token=AAAXTFXZCADUQ3DUCC2EFRD4SY743A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMBRHE3TQNZSHA32M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOS6XA4S7OJSXM2LFO5PW433UNFTGSY3BORUW63TTL5RWY2LDNM#pullrequestreview-4019787287>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAXTFRO3NGOJR4OSWYQG2D4SY743AVCNFSM6AAAAACXBBIBP6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DAMJZG44DOMRYG4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've always had this special step in the release process to add all of our source code as a release artifact, but GitHub does all of this for you by default when you make a release, so it's just duplicate work. This probably made more sense when we had a Ruby submodule and might have been trying specifically to include the Ruby source, but I don't think we need it anymore.