Add copy to clipboard#3056
Conversation
mwestphal
left a comment
mwestphal
left a comment
There was a problem hiding this comment.
Please feel free to request a review whenever needed ;)
|
Can I run CI? I'm not entirely sure if I built/linked the clip library properly for all platforms |
Ha, we have a slight issue with the comment system at the moment, let me run it for you. |
|
looks like it was able to build properly, however, inside the clip library, there are type warnings that the compiler is treaing as errors. Do I modify the clip library in |
RealEdwardS
force-pushed
the
add-copy-to-clipboard
branch
from
39d2db7 to
86b9f2e
Compare
If we modify clip we should send the patch upstream (open a PR in clip and discuss with maintainers). If we cant do that for some reason, its better to disable to error when bulding this specific file. |
|
need any help moving forward @RealEdwardS ? |
| list(APPEND classes vtkF3DWebPReader) | ||
| endif() | ||
|
|
||
| if(F3D_MODULE_UI AND NOT F3D_USE_EXTERNAL_IMGUI) |
There was a problem hiding this comment.
Create your own F3D_USE_EXTERNAL_CLIP to handle imgui and clip separately
There was a problem hiding this comment.
should clip still be part of F3D_MODULE_UI even if it's separate from imgui?
There was a problem hiding this comment.
i dont think it should be part of F3D_MODULE_UI
| set(f3d_strict_build_compile_options /W4) | ||
| set(f3d_strict_build_link_options) | ||
| else() | ||
| set(f3d_strict_build_compile_options -Wall -Wextra -Wshadow -Woverloaded-virtual -Wno-deprecated -Wno-strict-overflow -Wno-array-bounds -Wunreachable-code -Wno-missing-field-initializers -Wno-unused-parameter -Wredundant-decls -Wpointer-arith -Werror) |
There was a problem hiding this comment.
I see this is a temp commit to try and fix things, let me know if you need any help with that.
mwestphal
left a comment
mwestphal
left a comment
There was a problem hiding this comment.
not done yet, let us know if you need guidance :)
RealEdwardS
force-pushed
the
add-copy-to-clipboard
branch
from
1c6f325 to
08d6243
Compare
RealEdwardS
force-pushed
the
add-copy-to-clipboard
branch
from
67ac019 to
2d13bbe
Compare
|
Style Checks CI failed: |
|
@mwestphal For Linux, the clip library requires the libx11-dev/libX11-devel package, how shall I go about installing this package? |
2 participants
Describe your changes
Issue ticket number and link if any
#2305
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampAI Disclosure
Continuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.