Improve default HDRI#2969
Conversation
|
\ci fast |
|
I think it's fine to change it to be honest. Worst case is users complaining but we can give the old HDRI file and associated config entries to revert to the old behavior. |
Do you mean as a proper CLI option or just as a file to use with |
|
yes |
Ok. thanks this MR can proceed. |
|
\ci main |
|
The default color or mesh without texture need to be changed to something more gray. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2969 +/- ##
==========================================
- Coverage 97.05% 97.04% -0.02%
==========================================
Files 213 213
Lines 17546 17547 +1
==========================================
- Hits 17029 17028 -1
- Misses 517 519 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
3ceb467 to
0d2b2e2
Compare
|
Hi @Ni-g-3l , need any help moving forward ? Merging this in june is important to avoid bad surprises before 4.0 :) |
|
\ci full |
|
I'm afraid you need a rebase on master and recover baselines again. sorry about that :/ |
|
Done ! I'm waiting for the CI to ensure that all baseline are correctly generated |
Thanks! Ill make sure this get merged before we change all baselines, again ^^ |
Describe your changes
This PR update the default HDRI according to what we decide on discord.
Issue ticket number and link if any
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampContinuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.