Skip to content

Improve default HDRI#2969

Open
Ni-g-3l wants to merge 35 commits into
f3d-app:masterfrom
Ni-g-3l:new-default-hdr
Open

Improve default HDRI#2969
Ni-g-3l wants to merge 35 commits into
f3d-app:masterfrom
Ni-g-3l:new-default-hdr

Conversation

@Ni-g-3l

@Ni-g-3l Ni-g-3l commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

Describe your changes

This PR update the default HDRI according to what we decide on discord.

Issue ticket number and link if any

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

@Ni-g-3l

Ni-g-3l commented Mar 24, 2026

Copy link
Copy Markdown
Contributor Author

\ci fast

@mwestphal mwestphal self-requested a review March 24, 2026 09:43
@mwestphal

Copy link
Copy Markdown
Member

@Ni-g-3l Im not sure we want to make it default right now, but we want to provide it and let users opt in with CL option/libf3d options.

Wdyt @Meakk ?

@Meakk

Meakk commented Mar 24, 2026

Copy link
Copy Markdown
Member

I think it's fine to change it to be honest. Worst case is users complaining but we can give the old HDRI file and associated config entries to revert to the old behavior.

@mwestphal

mwestphal commented Mar 24, 2026

Copy link
Copy Markdown
Member

I think it's fine to change it to be honest. Worst case is users complaining but we can give the old HDRI file and associated config entries to revert to the old behavior.

Do you mean as a proper CLI option or just as a file to use with --hdri-file ?

@Meakk

Meakk commented Mar 24, 2026

Copy link
Copy Markdown
Member

yes

@mwestphal

Copy link
Copy Markdown
Member

a file to use with --hdri-file ?

Ok. thanks this MR can proceed.

@Ni-g-3l

Ni-g-3l commented Mar 24, 2026

Copy link
Copy Markdown
Contributor Author

\ci main

Comment thread testing/baselines/TestThumbnailConfigFileHDR.png
@mwestphal

Copy link
Copy Markdown
Member

The default color or mesh without texture need to be changed to something more gray.

@codecov

codecov Bot commented Apr 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.04%. Comparing base (4102575) to head (5e30b2a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2969      +/-   ##
==========================================
- Coverage   97.05%   97.04%   -0.02%     
==========================================
  Files         213      213              
  Lines       17546    17547       +1     
==========================================
- Hits        17029    17028       -1     
- Misses        517      519       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mwestphal mwestphal added this to the 3.6.0 milestone Apr 17, 2026
Comment thread vtkext/private/module/vtkF3DRenderer.cxx Outdated

@mwestphal mwestphal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Now just needs new baselines.

@mwestphal mwestphal modified the milestones: 3.6.0, 4.0.0 May 13, 2026
@mwestphal

Copy link
Copy Markdown
Member

Hi @Ni-g-3l , need any help moving forward ? Merging this in june is important to avoid bad surprises before 4.0 :)

@mwestphal mwestphal linked an issue May 28, 2026 that may be closed by this pull request
Comment thread cmake/f3dTest.cmake Outdated
@Ni-g-3l

Ni-g-3l commented Jun 7, 2026

Copy link
Copy Markdown
Contributor Author

\ci full

Comment thread cmake/f3dTest.cmake Outdated
Comment thread cmake/f3dTest.cmake Outdated
@mwestphal

mwestphal commented Jun 9, 2026

Copy link
Copy Markdown
Member

I'm afraid you need a rebase on master and recover baselines again. sorry about that :/

@Ni-g-3l

Ni-g-3l commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Done ! I'm waiting for the CI to ensure that all baseline are correctly generated

@mwestphal

Copy link
Copy Markdown
Member

Done ! I'm waiting for the CI to ensure that all baseline are correctly generated

Thanks! Ill make sure this get merged before we change all baselines, again ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve default HDRI

3 participants