Skip to content

chore: update everything to the new repository#243

Open
Skarlso wants to merge 6 commits intoexternal-secrets:mainfrom
Skarlso:update-everything
Open

chore: update everything to the new repository#243
Skarlso wants to merge 6 commits intoexternal-secrets:mainfrom
Skarlso:update-everything

Conversation

@Skarlso
Copy link
Contributor

@Skarlso Skarlso commented Mar 2, 2026

No description provided.

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Copy link

@evrardjp evrardjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not do a complete review, but it mnakes sense to at least fix that.
I don't want to block next changes and it's positive, so let's merge.

@evrardjp
Copy link

evrardjp commented Mar 2, 2026

I forgot to say that I double-checked for no occurence of external-secrets-inc.

@Skarlso
Copy link
Contributor Author

Skarlso commented Mar 3, 2026

Oh! That workflow shouldn't even run. I'm in a fork..

Skarlso added 2 commits March 3, 2026 21:47
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso
Copy link
Contributor Author

Skarlso commented Mar 3, 2026

Oh my f*cking gods, I also have to update ESO in this thing. I'm gonna die. :D

@evrardjp
Copy link

evrardjp commented Mar 4, 2026

Can't this be another pr ? I mean it's a different topic to fix ci ...

@evrardjp
Copy link

evrardjp commented Mar 4, 2026

At the same time you wrote "Update everything" 😅

Skarlso added 2 commits March 4, 2026 08:30
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso
Copy link
Contributor Author

Skarlso commented Mar 4, 2026

No idea what the fuck trivy's problem is

➜ trivy image ghcr.io/external-secrets/reloader:0.0.5-66.g0613ed5
2026-03-04T09:26:03+01:00       INFO    [vuln] Vulnerability scanning is enabled
2026-03-04T09:26:03+01:00       INFO    [secret] Secret scanning is enabled
2026-03-04T09:26:03+01:00       INFO    [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2026-03-04T09:26:03+01:00       INFO    [secret] Please see https://trivy.dev/docs/v0.69/guide/scanner/secret#recommendation for faster secret detection
2026-03-04T09:26:04+01:00       INFO    Detected OS     family="debian" version="13.3"
2026-03-04T09:26:04+01:00       INFO    [debian] Detecting vulnerabilities...   os_version="13" pkg_num=5
2026-03-04T09:26:04+01:00       INFO    Number of language-specific files       num=1
2026-03-04T09:26:04+01:00       INFO    [gobinary] Detecting vulnerabilities...

Report Summary

┌───────────────────────────────────────────────────────────────────┬──────────┬─────────────────┬─────────┐
│                              Target                               │   Type   │ Vulnerabilities │ Secrets │
├───────────────────────────────────────────────────────────────────┼──────────┼─────────────────┼─────────┤
│ ghcr.io/external-secrets/reloader:0.0.5-66.g0613ed5 (debian 13.3) │  debian  │        0        │    -    │
├───────────────────────────────────────────────────────────────────┼──────────┼─────────────────┼─────────┤
│ usr/bin/reloader                                                  │ gobinary │        0        │    -    │
└───────────────────────────────────────────────────────────────────┴──────────┴─────────────────┴─────────┘
Legend:
- '-': Not scanned
- '0': Clean (no security findings detected)
- ```

Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
@Skarlso
Copy link
Contributor Author

Skarlso commented Mar 4, 2026

YESSSSSS!!!!!!!!!!!!!!!! 🎉

@evrardj-roche
Copy link

evrardj-roche commented Mar 4, 2026

Shouldn't we use a more recent version of trivy? With the recent security event I thought we needed 0.69.2 min. The rest could have been impacted .

Read also: aquasecurity/trivy#10265

@Skarlso
Copy link
Contributor Author

Skarlso commented Mar 4, 2026

Talked about this, we are good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants