Skip to content

chore: ensure safe config in the npmrc#7144

Open
sheplu wants to merge 1 commit intomasterfrom
safe-npmrc
Open

chore: ensure safe config in the npmrc#7144
sheplu wants to merge 1 commit intomasterfrom
safe-npmrc

Conversation

@sheplu
Copy link
Copy Markdown
Member

@sheplu sheplu commented Mar 31, 2026

Adding latest NPM permission on .npmrc - enforcing:

  • a wait time on update by default
  • ignore all post install scripts
  • block any git usage for packages

@sheplu
Copy link
Copy Markdown
Member Author

sheplu commented Mar 31, 2026

@expressjs/express-tc For review and let's discuss if we want that on all packages?

Comment thread .npmrc Outdated
@@ -1 +1,4 @@
package-lock=false
min-release-age=2
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
min-release-age=2
min-release-age=7

two days only seems low

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to 7

Copy link
Copy Markdown
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW this technically would mean our CI won't show broken builds from deps (direct or transitive) that users would get for 7 days. While I believe this change balances the risk I just wanted to call it out that we may consider having a bypass for this to test breakage that can occur from those deps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants