Skip to content

Sync triangle#1008

Open
Narkunan wants to merge 9 commits into
exercism:mainfrom
Narkunan:sync-triangle
Open

Sync triangle#1008
Narkunan wants to merge 9 commits into
exercism:mainfrom
Narkunan:sync-triangle

Conversation

@Narkunan

Copy link
Copy Markdown
Contributor

Fix issue #984

@github-actions

Copy link
Copy Markdown

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@Narkunan

Copy link
Copy Markdown
Contributor Author

Hi @mk-mxp I hope You had great with your vacation. I know this build will fail but i want to raise a PR Because I want to discuss some test cases.

  1. 8d71e185-2bd7-4841-b7e1-71689a5491d8 – This test case satisfies both the equilateral and isosceles conditions. How should we handle this case?
  2. c6585b7d-a8c0-4ad8-8a34-e21d36f7ad87 – This test case satisfies the scalene condition, but it is expected to throw an exception if it is equilateral.
  3. 33eb6f87-0498-4ccf-9573-7f8c3ce92b7b – Same as test case 2.
  4. 2510001f-b44d-4d18-9872-2303e7977dc1 – This test case satisfies the equilateral triangle condition, but it is expected to be treated as **scalene.
  5. c6e15a92-90d9-4fb3-90a2-eef64f8d3e1e – This test case is expected to be scalene and throw an exception, but it also matches the **isosceles condition.
  6. 3da23a91-a166-419a-9abf-baf4868fd985 – Same as test case 5.
  7. b6a75d98-1fef-4c42-8e9a-9db854ba0a4d– Same as test case 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant