120 update openapi python client, fix vulnerabilities, update PTB to version 5 by ckunki · Pull Request #139 · exasol/saas-api-python

ckunki · 2026-02-16T07:30:35Z

This PR closes the following issues

Fix vulerabilities by updating dependencies #140
- This required updating dependency openapi-python-client
Update /openapi-python-client to version 0.26 or higher #120
- This required re-generating the SaaS API Python Client Code
- Also required adapting file api_access.py to process ApiErrors
SAPIPY: Update PTB to version 5 and regenerate workflows #141
- This required regenerating the GitHub workflows and fixing a number of lint errors
- Also, file noxconfig.py needed to be updated

Closes #120
Closes #141
Closes #140

ckunki · 2026-02-16T08:46:03Z

.github/workflows/slow-checks.yml

+        env:
+          SAAS_HOST: ${{ secrets.INTEGRATION_TEAM_SAAS_STAGING_HOST }}
+          SAAS_ACCOUNT_ID: ${{ secrets.INTEGRATION_TEAM_SAAS_STAGING_ACCOUNT_ID }}
+          SAAS_PAT: ${{ secrets.INTEGRATION_TEAM_SAAS_STAGING_PAT }}
+          PROJECT_SHORT_TAG: SAPIPY


Manually added

ckunki · 2026-02-16T08:56:40Z

.github/workflows/build-and-publish.yml

@@ -4,21 +4,24 @@ on:
  workflow_call:


The workflows are mainly generated by PTB, but updated in a few places, which are commented.

Manual updated were required mainly for

Add secrets for accessing SaaS instances

Re- integrate the slow tests, which were marked with pytest.mark.slow before

ckunki · 2026-02-16T09:00:18Z

.github/workflows/slow-checks.yml

+        env:
+          SAAS_HOST: ${{ secrets.INTEGRATION_TEAM_SAAS_STAGING_HOST }}
+          SAAS_ACCOUNT_ID: ${{ secrets.INTEGRATION_TEAM_SAAS_STAGING_ACCOUNT_ID }}
+          SAAS_PAT: ${{ secrets.INTEGRATION_TEAM_SAAS_STAGING_PAT }}
+          PROJECT_SHORT_TAG: SAPIPY


Manually added

ckunki · 2026-02-16T09:03:53Z

exasol/saas/client/api_access.py

@@ -1,16 +1,13 @@
 from __future__ import annotations



Main changes in this file are for handling results of type ApiError, which are new in version 0.26
of openapi-python-client.

Our updated implementation now raises an exception of type OpenApiError.

ckunki · 2026-02-16T09:04:58Z

exasol/saas/client/api_access.py

    wait_fixed,
 )

+import exasol.saas.client.openapi.models as openapi_models


The linter coming with PTB version 5 does no longer accept

from exasol.saas.client import openapi openapi.models.CreateDatabaseInitialCluster(...)

I think, we saw something similar in another project; the linter requires explicit exports if you want to import things. The explicit export can be happen by definition or by __all__

sonarqubecloud · 2026-02-17T09:58:47Z

Quality Gate failed

Failed conditions
78.1% Coverage on New Code (required ≥ 80%)
1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

tkilias · 2026-02-17T14:28:55Z

exasol/saas/client/api_access.py

+        try:
+            return still_exists()
+        except (TryAgain, RetryError) as ex:
+            raise DatabaseDeleteTimeout from ex


I guess the main reason for this change is that you can chain the original exception

tkilias · 2026-02-17T14:35:57Z

test/unit/test_api_access.py

 class ApiRunner:
-    def __init__(self, mocker):
+    def __init__(self, monkeypatch):
        self.api = OpenApiAccess(Mock(), account_id="A1")
-        self._mocker = mocker
+        self._monkeypatch = monkeypatch
        self.mock = None

    def mock_delete(self, side_effect):
+        from exasol.saas.client.api_access import delete_database as api
+
        self.mock = Mock(side_effect=side_effect)
-        self._mocker.patch(
-            "exasol.saas.client.api_access." "delete_database.sync_detailed", self.mock
-        )
+        self._monkeypatch.setattr(api, "sync_detailed", self.mock)


This thing is a bit weird

tkilias · 2026-02-17T15:06:14Z

test/integration/connection_test.py

hm, the file name is a bit weird. I know it is possible with pytest, but all other places use test_*

tkilias · 2026-02-17T15:06:35Z

test/integration/databases_test.py

hm, the file name is a bit weird. I know it is possible with pytest, but all other places use test_*

ckunki added 4 commits February 15, 2026 12:56

updated dependencies, adapted to PTB version 5

3561b84

Updated changelog

74a9a45

Re-generated workflows and fixed typing errors

0302f93

updated changelog

d00b507

ckunki temporarily deployed to manual-approval February 16, 2026 07:30 — with GitHub Actions Inactive

Moved file version.py

7a9560f

ckunki temporarily deployed to manual-approval February 16, 2026 07:32 — with GitHub Actions Inactive

re-generated API using updated openapi-python-client

cb72387

ckunki requested a deployment to manual-approval February 16, 2026 07:36 — with GitHub Actions Waiting

Wrapped calls to inner API to raise OpenApiError

fa69368

ckunki requested a deployment to manual-approval February 16, 2026 07:51 — with GitHub Actions Waiting

reformatted generated code

ceea86c

ckunki temporarily deployed to manual-approval February 16, 2026 07:55 — with GitHub Actions Inactive

Added missing import

06cfb73

ckunki temporarily deployed to manual-approval February 16, 2026 07:59 — with GitHub Actions Inactive

ckunki commented Feb 16, 2026

View reviewed changes

updated changelog

26e881d

ckunki changed the title ~~120 update openapi python client~~ 120 update openapi python client, fix vulnerabilities, update PTB to version 5 Feb 16, 2026

ckunki commented Feb 16, 2026

View reviewed changes

increased timeout in tests

3b29d66

ckunki temporarily deployed to manual-approval February 16, 2026 09:12 — with GitHub Actions Inactive

poetry lock

fbd8087

ckunki temporarily deployed to manual-approval February 16, 2026 09:17 — with GitHub Actions Inactive

Modified API

4b7f579

ckunki temporarily deployed to manual-approval February 16, 2026 10:41 — with GitHub Actions Inactive

Added instrumentation for failing test

6ec206d

ckunki temporarily deployed to manual-approval February 16, 2026 11:15 — with GitHub Actions Inactive

Hopefullly finally fixed delete implementation

1bf55a2

ckunki requested a deployment to manual-approval February 16, 2026 13:56 — with GitHub Actions Waiting

format:fix

589556c

ckunki requested a deployment to manual-approval February 16, 2026 13:57 — with GitHub Actions Waiting

Cleanup

95ae0e6

ckunki temporarily deployed to manual-approval February 16, 2026 14:00 — with GitHub Actions Inactive

fixed lint errors

4291d07

ckunki requested a deployment to manual-approval February 16, 2026 14:14 — with GitHub Actions Waiting

Fixed unit tests

ebd682f

ckunki requested a deployment to manual-approval February 16, 2026 15:34 — with GitHub Actions Waiting

nox -s format:fix

7bd6c0c

ckunki temporarily deployed to manual-approval February 16, 2026 15:36 — with GitHub Actions Inactive

Removed local test case

5ce143a

ckunki requested a deployment to manual-approval February 16, 2026 16:14 — with GitHub Actions Waiting

Removed unused import

163838b

ckunki temporarily deployed to manual-approval February 16, 2026 16:14 — with GitHub Actions Inactive

Cleaned up log messages and unit test

1eaa7ff

ckunki temporarily deployed to manual-approval February 16, 2026 16:42 — with GitHub Actions Inactive

ckunki added 2 commits February 17, 2026 09:03

nox -s format:fix

514a882

Refactored error messages and unit tests

9a391f6

ckunki requested a deployment to manual-approval February 17, 2026 08:18 — with GitHub Actions Waiting

nox -s format:fix

a663b62

ckunki requested a deployment to manual-approval February 17, 2026 08:18 — with GitHub Actions Waiting

Removed output

8ff9f55

ckunki deployed to manual-approval February 17, 2026 08:20 — with GitHub Actions Active

tkilias reviewed Feb 17, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

120 update openapi python client, fix vulnerabilities, update PTB to version 5#139

120 update openapi python client, fix vulnerabilities, update PTB to version 5#139
ckunki wants to merge 30 commits intomainfrom
refactoring/120-Update_openapi-python-client

ckunki commented Feb 16, 2026 •

edited

Loading

Uh oh!

ckunki Feb 16, 2026

Uh oh!

ckunki Feb 16, 2026 •

edited

Loading

Uh oh!

ckunki Feb 16, 2026

Uh oh!

ckunki Feb 16, 2026

Uh oh!

ckunki Feb 16, 2026 •

edited

Loading

Uh oh!

tkilias Feb 17, 2026 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Feb 17, 2026

Uh oh!

tkilias Feb 17, 2026

Uh oh!

tkilias Feb 17, 2026 •

edited

Loading

Uh oh!

tkilias Feb 17, 2026

Uh oh!

tkilias Feb 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ckunki commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ckunki Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

ckunki Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ckunki Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

ckunki Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

ckunki Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tkilias Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Feb 17, 2026

Quality Gate failed

Uh oh!

tkilias Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

tkilias Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tkilias Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

tkilias Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ckunki commented Feb 16, 2026 •

edited

Loading

ckunki Feb 16, 2026 •

edited

Loading

ckunki Feb 16, 2026 •

edited

Loading

tkilias Feb 17, 2026 •

edited

Loading

tkilias Feb 17, 2026 •

edited

Loading