Open
Conversation
ArBridgeman
requested a deployment
to
manual-approval
GitHub Actions
Waiting
tkilias
reviewed
Feb 17, 2026
|
|
||
| @classmethod | ||
| def load_from_template(cls, file_path: Path, github_template_dict: dict[str, Any]): | ||
| bind_contextvars(template_file_name=file_path.name) |
Collaborator
There was a problem hiding this comment.
Is it intended, that this doesn't get cleared when the not file_path.exists(): fails?
Collaborator
Author
There was a problem hiding this comment.
No, it was an oversight. Still popping off parts from the OG PR ;)
tkilias
reviewed
Feb 17, 2026
exasol/toolbox/__init__.py
Outdated
| log_level = os.getenv("LOG_LEVEL", "INFO").upper() | ||
|
|
||
| structlog.configure( | ||
| wrapper_class=structlog.make_filtering_bound_logger(getattr(logging, log_level)) |
Collaborator
There was a problem hiding this comment.
Ah, ok you only wrap normal logging and don't use the json logging. This should be the best for PTB. It is mainly read by humans.
ArBridgeman
requested a deployment
to
manual-approval
GitHub Actions
Waiting
ArBridgeman
requested a deployment
to
manual-approval
GitHub Actions
Waiting
ArBridgeman
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #712
Checklist
Note: If any of the items in the checklist are not relevant to your PR, just check the box.
For any Pull Request
Is the following correct:
When Changes Were Made
Did you:
When Preparing a Release
Have you: