Skip to content

[7.x.x] Fix a memory/resource leak in the sql:execute XPath functions #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adamretter wants to merge 1 commit into
base: develop-7.x.x
Choose a base branch
from
Open

[7.x.x] Fix a memory/resource leak in the sql:execute XPath functions #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion extensions/modules/sql/src/main/java/org/exist/xquery/modules/sql/ExecuteFunction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,8 +428,9 @@ private ElementImpl resultAsElement(final boolean makeNodeFromColumnName, final
//get the content
if (rsmd.getColumnType(i + 1) == Types.SQLXML) {
//parse sqlxml value
@Nullable SQLXML sqlXml = null;
try {
final SQLXML sqlXml = rs.getSQLXML(i + 1);
sqlXml = rs.getSQLXML(i + 1);

if (rs.wasNull()) {
// Add a null indicator attribute if the value was SQL Null
Expand All @@ -455,7 +456,12 @@ private ElementImpl resultAsElement(final boolean makeNodeFromColumnName, final
}
} catch (final Exception e) {
throw new XPathException(this, "Could not parse column of type SQLXML: " + e.getMessage(), e);
} finally {
if (sqlXml != null) {
sqlXml.free();
}
}

} else {
//otherwise assume string value
final String colValue = rs.getString(i + 1);
Expand Down
Loading