Skip to content

fix sass warning#8006

Open
gilluminate wants to merge 1 commit intomainfrom
gill/fix-sass-warning-nextjs
Open

fix sass warning#8006
gilluminate wants to merge 1 commit intomainfrom
gill/fix-sass-warning-nextjs

Conversation

@gilluminate
Copy link
Copy Markdown
Contributor

@gilluminate gilluminate commented Apr 22, 2026

Description Of Changes

fixes an annoying sass warning during NextJS builds

Code Changes

  • re-order style to be above the & extensions in ActivityTimelineEntry.module.scss

Steps to Confirm

  1. NextJS build no longer shows a warning on line 88 of ActivityTimelineEntry.module.scss

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Apr 22, 2026 7:00pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Apr 22, 2026 7:00pm

Request Review

@gilluminate gilluminate marked this pull request as ready for review April 22, 2026 19:00
@gilluminate gilluminate requested a review from a team as a code owner April 22, 2026 19:00
@gilluminate gilluminate requested review from lucanovera and removed request for a team April 22, 2026 19:00
@github-actions
Copy link
Copy Markdown

Title Lines Statements Branches Functions
admin-ui Coverage: 8%
6.34% (2799/44095) 5.59% (1402/25061) 4.43% (579/13042)
fides-js Coverage: 78%
78.98% (1962/2484) 65.55% (1214/1852) 72.57% (336/463)
privacy-center Coverage: 88%
85.97% (331/385) 81.36% (179/220) 78.87% (56/71)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant