Skip to content

ENG-3184: Migrate EditMinimalDataUseModal to antd Form#7989

Open
jpople wants to merge 6 commits intomainfrom
jpople/eng-3184/migrate-edit-data-use-modal
Open

ENG-3184: Migrate EditMinimalDataUseModal to antd Form#7989
jpople wants to merge 6 commits intomainfrom
jpople/eng-3184/migrate-edit-data-use-modal

Conversation

@jpople
Copy link
Copy Markdown
Contributor

@jpople jpople commented Apr 21, 2026

Ticket ENG-3184

Description Of Changes

Migrates the EditMinimalDataUseModal component from Formik/Chakra UI to antd Form components, as part of the ongoing Chakra → Ant Design migration.

Key changes:

  • Formik (useFormik, FormikProvider, <Form>) → antd Form.useForm + <Form>
  • Yup validation schema → antd rules on Form.Item
  • ControlledSelectForm.Item + Select
  • CustomTextInputForm.Item + Input
  • CustomSwitchForm.Item + Switch (with valuePropName="checked", layout="horizontal")
  • ChakraCollapseExpandCollapse (fidesui motion-based component)
  • ChakraStackFlex vertical
  • ChakraTextTypography.Text
  • useChakraDisclosureuseState
  • Dirty/valid tracking via Form.useWatch + lodash isEqual

Code Changes

  • Replaced all Formik form state management with antd Form API
  • Replaced all Chakra UI components with antd equivalents
  • Added aria-label to all Select components for accessibility compliance
  • Used ExpandCollapse from fidesui for animated show/hide sections

Steps to Confirm

  1. Create a system with a BigQuery integration, add a monitor, and run a scan
  2. Navigate to the Data Catalog and select your system
  3. Create a data use and click "Edit" on it
  4. Verify the modal opens with the correct initial values
  5. Verify the "Data use" field is required (try submitting empty)
  6. Verify multi-select fields (Data categories, Data subjects) work correctly
  7. Toggle "Advanced settings" and verify the section expands/collapses smoothly
  8. Select "Legitimate interests" as legal basis and verify the impact assessment field appears
  9. Toggle "This system processes special category data" and verify the legal basis select appears
  10. Make changes and verify the Save button enables only when the form is dirty and valid
  11. Click Cancel and verify dirty form shows a confirmation dialog

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Apr 23, 2026 3:18pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Apr 23, 2026 3:18pm

Request Review

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

Title Lines Statements Branches Functions
admin-ui Coverage: 8%
6.34% (2799/44105) 5.59% (1402/25063) 4.43% (579/13048)
fides-js Coverage: 78%
78.98% (1962/2484) 65.55% (1214/1852) 72.57% (336/463)
privacy-center Coverage: 88%
85.97% (331/385) 81.36% (179/220) 78.87% (56/71)

@jpople jpople requested a review from a team as a code owner April 23, 2026 15:16
@jpople jpople requested review from speaker-ender and removed request for a team April 23, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant