Skip to content

ENG-3254: surface extracted log data#7975

Open
tvandort wants to merge 11 commits intomainfrom
ENG-3254
Open

ENG-3254: surface extracted log data#7975
tvandort wants to merge 11 commits intomainfrom
ENG-3254

Conversation

@tvandort
Copy link
Copy Markdown
Contributor

@tvandort tvandort commented Apr 20, 2026

Ticket ENG-3254

Description Of Changes

  • Show View N Logs on all clickable Privacy request activity timeline rows that are clickable.
  • Add N to hint to user whether it's worthwhile to click in
  • Add further (i) hint to say where there are extracted logs to view

Steps to Confirm

1. Run provided express server

const express = require("express");
const bodyParser = require("body-parser");

const app = express();
const port = 8082;

app.use(bodyParser.json());

function printRequest(req) {
  console.log("Headers: ", req.headers);
  console.log("Body:", req.body);
}

app.all("/test-connection", (req, res) => {
  printRequest(req);
  res.send("test-connection");
});

app.post("/pre-approval-1", (req, res) => {
  printRequest(req);
  // res.status(401).send({ message: "example" });
  res.send("pre-approval-1");
});

app.post("/pre-execution-1", (req, res) => {
  printRequest(req);
  res
    .json({
      halt: "true", // set to true to pause execution; false to proceed
    })
    .send();
});

app.post("/fake-integration", (req, res) => {
  printRequest(req);
  res.json({ message: "it is here" }).send();
});

app.post("/test", (req, res) => {
  printRequest(req);
  res.status(200).send();
});

app.get("/", (req, res) => {
  printRequest(req);
  res.send("index");
});

app.listen(port, () => {
  console.log(`Example app listening on port ${port}`);
});

2. Run ngrok pointed at express server

ngrok http http://localhost:8082

3. Configure integration as follows

example_config.yaml

saas_config:
  fides_key: <instance_fides_key>
  name: Example
  type: Example
  description: Echoes
  version: 0.1.29

  connector_params:
    - name: domain
      description: ngrok domain
    - name: endpoint
      description: ngrok endpoint
    - name: test_endpoint
      description: ngrok test endpoint

  client_config:
    protocol: https
    host: <domain>
    authentication:
      strategy: api_key
      configuration:
        headers:
          - name: x-api-key
            value: api_key_value

  test_request:
    method: POST
    path: /test
    body: |
      {
        "example": "example_value"
      }

  endpoints:
    - name: examples
      requests:
        delete:
          param_values:
            - name: email
              identity: email
            - name: amg_uuid
              identity: amg_uuid
            - name: sources
              identity: sources
          method: POST
          path: /fake-integration
          body: |
            {
              "email": "<email>",
              "amg_uuid": "<amg_uuid.value?>"
            }
          postprocessors:
            - strategy: extract_for_execution_log
              configuration:
                path: ~

example_dataset.yaml

dataset:
  - fides_key: <instance_fides_key>
    name: Example
    description: Echoes
    collections:
      - name: examples
        fields: []

image

4. Run an erasure DSR and observe

Counts on log rows
image

Extracted log tooltip
image

Json content when extracted log is viewed
image

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Apr 21, 2026 2:30pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Apr 21, 2026 2:30pm

Request Review

@tvandort tvandort marked this pull request as ready for review April 21, 2026 13:28
@tvandort tvandort requested a review from a team as a code owner April 21, 2026 13:28
@tvandort tvandort requested review from kruulik and removed request for a team April 21, 2026 13:28
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

Title Lines Statements Branches Functions
admin-ui Coverage: 8%
6.36% (2804/44048) 5.6% (1404/25033) 4.45% (580/13029)
fides-js Coverage: 78%
78.98% (1962/2484) 65.55% (1214/1852) 72.57% (336/463)
privacy-center Coverage: 88%
85.97% (331/385) 81.36% (179/220) 78.87% (56/71)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant