Fix FailedToObtainBlockhash in case of empty slots #506
Open
Fix FailedToObtainBlockhash in case of empty slots #506
FailedToObtainBlockhash in case of empty slots #506Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The
FailedToObtainBlockhashissue was reproduced:Cause
The chain head stayed as 10,414,872 for 3 slots during the block mined and tx estimated. The fix in #487 only waits for 1 slot at most.
We need the block number updates to avoid empty blockhash.
Solution
This PR replaces slot-based waiting with a channel-based synchronization that ensures mining results are only submitted after the L1 head has advanced past the mined block.
Tests
Tests done in local devnet:
Waiting for L1 head to advance in the case of an empty slot:
Normal case: