Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
|
Closing this because it's superseded by #10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches to a server-side rendering approach.
Background
Initially, all logic happened at runtime on the client side. Blips shipped as a static shell and had the browser fetch the blip content data and render it. This was easy to implement, but it had terrible client-side performance.
Then, in PR #3, I switched to an SSG-and-webhook approach. All fetching and rendering logic happened at build time. Whenever a new blip was published, it would trigger a webhook and re-build the site. This was fantastic for performance, but the webhook added complexity and fragility and it introduced a delay between when a blip is published and when it appeared to viewers.
New approach
With this PR, the blips are fetched and rendered on each request via Svelte-Kit's
adapter-auto. In testing, this doesn't seem to noticeably affect page load times or performance, but it removes the need for the webhook and it allows for instant content updates.However, the downside is that it doesn't support GitHub Pages anymore. GH Pages only supports static sites, and SSR is by definition not static. For this reason, I won't be merging this PR until I'm ready to abandon GitHub Pages and switch completely to Vercel.