bugc: flatten TCO back-edge JUMP context#214
Open
gnidan wants to merge 1 commit intotransform-contextfrom
Open
bugc: flatten TCO back-edge JUMP context#214gnidan wants to merge 1 commit intotransform-contextfrom
gnidan wants to merge 1 commit intotransform-contextfrom
Conversation
The TCO back-edge JUMP previously emitted a gather wrapper around its invoke and return contexts. Multiple discriminator keys can coexist on a single context object without gather wrapping, so the JUMP now carries a flat combined context with both `invoke` and `return` keys directly. Updates the countCallSites helper in optimizer-contexts.test to check invoke and return independently rather than as an either/or, so flat multi-discriminator contexts get counted in both buckets. The TCO-specific assertion now finds the back-edge JUMP by the presence of both discriminators rather than by a gather wrapper.
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The TCO back-edge JUMP previously wrapped its invoke and return contexts in a gather. Multiple discriminator keys can coexist on a single context object, so the JUMP now carries a flat combined context with both
invokeandreturndirectly.Applies to future annotation emissions as well (e.g., the upcoming inlining pass will combine
invokewithtransformwithout gather wrapping).Changes
evmgen/generation/control-flow/terminator.ts—buildTailCallJumpOptionsemits{ return: {...}, invoke: {...} }directlyevmgen/optimizer-contexts.test.ts—countCallSiteshelper now checks invoke and return independently so flat multi-discriminator contexts get counted in both buckets; TCO-specific assertion finds the back-edge JUMP by the presence of both discriminators rather than by gather wrapperTest plan
optimizer-contexts.test.tspasses (31/31) at all levels