Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 387f266a47
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| run: dotnet format WhileLoopTimeout.sln --verify-no-changes | ||
|
|
||
| build: | ||
| if: github.event_name != 'pull_request' |
There was a problem hiding this comment.
The new job guard if: github.event_name != 'pull_request' means PR workflows now skip the entire build/test pipeline and only run formatting. In the current workflow this removes compile and test validation for all pull requests, so regressions can merge undetected until after landing on master.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c090f3e8ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| set -euo pipefail | ||
| steamcmd \ | ||
| '+@sSteamCmdForcePlatformType windows' \ | ||
| '+force_install_dir "${RESONITE_INSTALL_DIR}"' \ |
There was a problem hiding this comment.
In pull_request runs, this command passes +force_install_dir "${RESONITE_INSTALL_DIR}" inside single quotes, so Bash does not expand ${RESONITE_INSTALL_DIR} before invoking SteamCMD. That makes SteamCMD use a literal placeholder path instead of ${{ github.workspace }}/.resonite, which means FrooxEngine.dll is not placed where the build expects it and PR builds silently switch to the Resonite.GameLibs fallback rather than validating against downloaded Resonite assemblies.
Useful? React with 👍 / 👎.
1 participant
概要
ci.ymlを現行の build/test/release 形に更新ローカル検証
dotnet restore .\WhileLoopTimeout.sln -p:ResonitePath="C:\Program Files (x86)\Steam\steamapps\common\Resonite\"dotnet test .\WhileLoopTimeout.sln -c Release --no-restore -p:ResonitePath="C:\Program Files (x86)\Steam\steamapps\common\Resonite\"