feat(skills): admin skills management parity (#55)#56
Merged
Conversation
Port the Laravel reference Users management surface (escalated-laravel #94) to a native WordPress admin screen. New Users submenu lists WP users with their Escalated admin/agent state, supports name/email search, and is paginated 20 per page. Admins can grant or revoke the escalated_admin / escalated_agent roles per user. The same self-demote guard and admin->agent cascade rules as the Laravel reference apply. WordPress deviation: instead of toggling is_admin / is_agent columns on a host User row, the toggle flips native WP roles (escalated_admin, escalated_agent) on the WP_User — that is the permission surface every other Escalated admin gate already uses (see Activator::create_roles / add_admin_caps). Gated by the existing escalated_user_manage capability. Tests: 7 PHPUnit cases mirroring tests/Feature/Admin/UserControllerTest in the Laravel reference (list/search renders, capability gate, admin promotion cascade, agent-only promotion, self-demote guard, agent-revoke-on-admin cascade, search filter).
Add escalated_skills schema, REST admin routes, SkillRoutingService, WP admin UI, and PHPUnit coverage per skills-management contract. Bump plugin version so maybe_upgrade runs dbDelta for existing installs. Co-authored-by: Cursor <cursoragent@cursor.com>
…/delete_item WP_REST_Controller declares these methods as `update_item($request)` and `delete_item($request)` with no class hint. Adding WP_REST_Request to the override triggers PHP's LSP variance check and aborts boot with a fatal.
Member
Author
|
Skills parity for #55 complete. Manual fixes during review:
CI green: lint + test (PHP 8.1 & 8.2). Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Closes #55
Made with Cursor