Draft
Conversation
…vas element * Introduced a new "e2e" script in package.json for running Playwright tests. * Added a data-testid attribute to the canvas element in CanvasWrapper for improved testability.
* Added Playwright as a testing dependency in package.json and pnpm-lock.yaml. * Updated canvas E2E tests to improve shape drawing and rotation functionality, ensuring stable snapshots. * Introduced data-testid attributes in the Toolbar component for better test targeting.
* Translated comments in the canvas E2E test file from Russian to English to improve readability and maintainability. * Ensured that the comments accurately describe the test steps for drawing and rotating shapes on the canvas.
* Modified canvas E2E tests to incorporate the latest shape management functionalities, ensuring accurate testing of shape addition, updating, and deletion. * Enhanced test coverage for the new EMPTY_SHAPES message type and its handling in the collaborative editing context.
* Implemented a comprehensive test for moving a rectangle in multiple directions (up, right, down, left) using Playwright. * Added steps for canvas interaction, including drawing a rectangle, selecting it, and performing the move actions. * Included a snapshot comparison to ensure visual consistency after movements.
…king * Added a mockWebSocket function to prevent real WebSocket connections during tests. * Updated rectangle E2E tests to include WebSocket mocking for drawing, moving, resizing, and rotating rectangles. * Adjusted wait times in move and resize tests for consistency and reliability. * Removed outdated snapshot images for draw tests and added new snapshots for move and resize tests.
…delays * Added a showCursor function to display a visible cursor overlay during tests for better debugging. * Updated rectangle E2E tests to include the cursor overlay for drawing, moving, resizing, and rotating rectangles. * Standardized wait times across tests to improve reliability and consistency in interactions.
…izing logic * Changed Playwright configuration to run tests in non-headless mode for better visibility during debugging. * Enhanced the `showCursor` function to improve cursor appearance and behavior during tests. * Refactored rectangle resizing tests to dynamically calculate handle positions based on rectangle coordinates. * Increased delay for resizing tests to ensure stability and reliability. * Removed outdated snapshot images and updated the snapshot for resizing tests to reflect recent changes.
…mages * Deleted the canvas E2E test file and all related snapshot images as they are no longer needed. * This cleanup helps maintain a tidy test suite and reduces unnecessary clutter.
… and click effects * Updated the `showCursor` function to include a more visually appealing cursor design with click animations. * Refactored cursor positioning logic for better performance and responsiveness during tests. * Enhanced the overall user experience in E2E tests by providing a clearer visual indication of cursor interactions.
…ance * Enhanced cursor functionality in E2E tests with updated styling and click effects. * Improved cursor positioning logic for better responsiveness during interactions. * Standardized wait times across tests to ensure consistent performance and reliability.
* Modified E2E workflow to trigger on pull requests for specific branches and paths. * Updated Playwright configuration to run tests in headless mode for improved performance. * Refactored rectangle E2E tests to utilize a shared DELAY constant for consistency. * Enhanced rectangle helper functions to streamline test logic and improve maintainability.
* Added a step to start the preview server for the frontend during E2E tests. * Included a wait step to ensure the frontend is ready before running tests, improving test reliability.
* Removed unnecessary newline in rectangle helper functions for cleaner code. * Commented out a wait timeout in the resize test for clarity. * Ensured consistent formatting by adding missing newlines at the end of E2E test files.
* Changed baseURL from 'http://localhost:5173' to 'http://localhost:4173' to align with the updated development server settings.
* Added steps to upload Playwright test results and snapshots as artifacts after E2E tests. * This improves test visibility and facilitates easier debugging by preserving test outputs.
* Updated the actions/upload-artifact version from v3 to v4 for both Playwright test results and snapshots. * This change ensures compatibility with the latest features and improvements in the artifact upload process.
* Added `if: always()` condition to the steps for uploading Playwright test results and snapshots, ensuring that these artifacts are uploaded regardless of the test outcome. This improves the reliability of test result retrieval for debugging purposes.
…r improved reliability * Implemented `if: always()` condition for artifact uploads in the E2E workflow, ensuring that Playwright test results and snapshots are uploaded regardless of test outcomes. This change enhances the reliability of test result retrieval for debugging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.