Skip to content

Remove redundant System using in ServerConnection#240

Merged
erikdarlingdata merged 1 commit intodevfrom
chore/remove-redundant-using-serverconnection
Apr 19, 2026
Merged

Remove redundant System using in ServerConnection#240
erikdarlingdata merged 1 commit intodevfrom
chore/remove-redundant-using-serverconnection

Conversation

@erikdarlingdata
Copy link
Copy Markdown
Owner

Summary

  • Drop using System; from ServerConnection.cs — already covered by .NET 8 implicit global usings.
  • Clears LSP warnings CS8933 (duplicate of global using) and CS8019 (unnecessary using).

Test plan

  • dotnet build is clean
  • No new diagnostics on the file

🤖 Generated with Claude Code

Clears CS8933 and CS8019 — System is already covered by the SDK's
implicit global usings.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@erikdarlingdata erikdarlingdata merged commit 4db4bc8 into dev Apr 19, 2026
2 checks passed
@erikdarlingdata erikdarlingdata deleted the chore/remove-redundant-using-serverconnection branch April 19, 2026 00:11
Copy link
Copy Markdown
Owner Author

Review

What it does: Removes using System; from src/PlanViewer.Core/Models/ServerConnection.cs:1. Single-line deletion.

Verified:

  • PlanViewer.Core.csproj:5 has <ImplicitUsings>enable</ImplicitUsings> on net8.0. The .NET SDK implicit global usings include System, so Guid (line 9), DateTime (lines 14–15), and InvalidOperationException (line 60) still resolve.
  • Base branch is dev — correct.
  • No Avalonia, XAML, or PlanAnalyzer changes; nothing to mirror to PerformanceMonitor Dashboard/Lite.
  • No src/ logic change, so no test gap in tests/PlanViewer.Core.Tests/.

Needs attention: None. Confirm dotnet build is clean as the PR's test plan calls out.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant