Add base64 encoding for shell command execution#26
Open
alexdremov wants to merge 2 commits intoepfml:mainfrom
Open
Add base64 encoding for shell command execution#26alexdremov wants to merge 2 commits intoepfml:mainfrom
alexdremov wants to merge 2 commits intoepfml:mainfrom
Conversation
Encode shell command in base64 and update command execution.
There was a problem hiding this comment.
Pull request overview
This PR changes how csub.py passes the user’s shell command to RunAI by base64-encoding the full zsh payload and decoding/executing it inside the container, aiming to avoid argument-quoting issues in RunAI’s command handling.
Changes:
- Base64-encode the generated
shell_commandbefore passing it to/bin/zsh -c. - Decode the payload inside the container and execute it via a temporary script file.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RunAI is doing some shitty business under the hood, and for example, quoted arguments (
'argument') are not passed correctly. Base64 encoding is a bulletproof solution.