fix(admin): center loading spinner under logo on login page#604
Open
all3f0r1 wants to merge 3 commits intoemdash-cms:mainfrom
Open
fix(admin): center loading spinner under logo on login page#604all3f0r1 wants to merge 3 commits intoemdash-cms:mainfrom
all3f0r1 wants to merge 3 commits intoemdash-cms:mainfrom
Conversation
…dash-cms#589) Tailwind Preflight sets SVGs to display:block, so text-align:center on the parent didn't center the Kumo <Loader /> SVG. Switch to flex column layout with items-center for reliable centering. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 3bd9a86 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/blocks
@emdash-cms/cloudflare
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The Kumo
<Loader />SVG wasn't visually centered under the logo on the login page loading state. Tailwind's Preflight sets SVGs todisplay: block, sotext-align: centeron the parent had no effect. Switched the wrapper to a flex column layout withitems-centerfor reliable centering.Closes #589
Type of change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (or targeted tests for my change)pnpm formathas been runpnpm locale:extracthas been run (if applicable)AI-generated code disclosure
Screenshots / test output
CSS-only change — the wrapper
divswitches fromtext-center(which doesn't center block-level SVGs) toflex flex-col items-center(which does).