Add url and email plugin setting field types (Issue #175) by Sayeem3051 · Pull Request #189 · emdash-cms/emdash

Sayeem3051 · 2026-04-03T17:07:03Z

This PR adds support for url and email plugin setting field types to resolve issue #175.

Added url and email to the SettingFieldType union in types.ts
Added UrlSettingField and EmailSettingField interfaces with optional default and placeholder fields
Added corresponding Zod schemas in manifest-schema.ts discriminated union

Closes #175

Type of change

Checklist

I have read CONTRIBUTING.md
pnpm typecheck passes
pnpm --silent lint:json | jq '.diagnostics | length' returns 0
pnpm test passes (or targeted tests for my change)
pnpm format has been run
I have added/updated tests for my changes (if applicable)
New features link to an approved Discussion: https://github.com/emdash-cms/emdash/discussions/...

AI-generated code disclosure

This PR includes AI-generated code

Screenshots / test output

Add UrlSettingField and EmailSettingField interfaces to the plugin settings schema. - Updated SettingFieldType union to include "url" and "email" - Added UrlSettingField and EmailSettingField interfaces - Updated SettingField union type Fixes emdash-cms#175

Add Zod schemas for url and email field types to the plugin setting field discriminated union in manifest-schema.ts, to resolve issue emdash-cms#175.

changeset-bot · 2026-04-03T17:07:10Z

⚠️ No Changeset found

Latest commit: 575714f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2026-04-03T17:07:14Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

Sayeem3051 · 2026-04-03T17:09:58Z

I have read the CLA Document and I hereby sign the CLA

ascorbic

Thanks!

Tests are failing

- Added missing closing brace after SecretSettingField's type property - Removed semicolon from SecretSettingField in the SettingField union type - This fixes the TypeScript TS(1070) error: 'export' modifier cannot appear on a type member - Fixes the CI Format check failure on PR emdash-cms#189

pkg-pr-new · 2026-04-12T12:18:37Z

Open in StackBlitz

@emdash-cms/admin

npm i https://pkg.pr.new/@emdash-cms/admin@189

@emdash-cms/auth

npm i https://pkg.pr.new/@emdash-cms/auth@189

@emdash-cms/blocks

npm i https://pkg.pr.new/@emdash-cms/blocks@189

@emdash-cms/cloudflare

npm i https://pkg.pr.new/@emdash-cms/cloudflare@189

emdash

npm i https://pkg.pr.new/emdash@189

create-emdash

npm i https://pkg.pr.new/create-emdash@189

@emdash-cms/gutenberg-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/gutenberg-to-portable-text@189

@emdash-cms/x402

npm i https://pkg.pr.new/@emdash-cms/x402@189

@emdash-cms/plugin-ai-moderation

npm i https://pkg.pr.new/@emdash-cms/plugin-ai-moderation@189

@emdash-cms/plugin-atproto

npm i https://pkg.pr.new/@emdash-cms/plugin-atproto@189

@emdash-cms/plugin-audit-log

npm i https://pkg.pr.new/@emdash-cms/plugin-audit-log@189

@emdash-cms/plugin-color

npm i https://pkg.pr.new/@emdash-cms/plugin-color@189

@emdash-cms/plugin-embeds

npm i https://pkg.pr.new/@emdash-cms/plugin-embeds@189

@emdash-cms/plugin-forms

npm i https://pkg.pr.new/@emdash-cms/plugin-forms@189

@emdash-cms/plugin-webhook-notifier

npm i https://pkg.pr.new/@emdash-cms/plugin-webhook-notifier@189

commit: cbbcd42

Copilot

Pull request overview

Adds new plugin setting field types (url, email) to the core plugin settings type system and manifest validation, enabling richer admin UI generation and schema support for plugins (Issue #175).

Changes:

Extended SettingFieldType / SettingField to include url and email field variants.
Added UrlSettingField and EmailSettingField interfaces (with default/placeholder).
Updated the plugin manifest Zod discriminated union to recognize url and email setting fields.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
packages/core/src/plugins/types.ts	Adds new setting field types/interfaces; updates the `SettingField` union.
packages/core/src/plugins/manifest-schema.ts	Extends manifest validation to accept `url` and `email` in `admin.settingsSchema`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

 	| BooleanSettingField
 	| SelectSettingField
-	| SecretSettingField;
+	| SecretSettingFiel


+	z.object({ ...baseSettingFields, type: z.literal("url") }),
+	z.object({ ...baseSettingFields, type: z.literal("email") }),


+	z.object({ ...baseSettingFields, type: z.literal("url") }),
+	z.object({ ...baseSettingFields, type: z.literal("email") }),


Added optional default and placeholder fields to url and email types in manifest schema.

Added tests for url and email field types in admin.settingsSchema.

github-actions · 2026-04-12T13:15:08Z

Overlapping PRs

This PR modifies files that are also changed by other open PRs:

feat(marketplace): expose github.clientId from discovery + harden publish auth #271 (3 shared files)

This may cause merge conflicts or duplicated work. A maintainer will coordinate.

Sayeem3051 added 2 commits April 3, 2026 22:29

Add url and email plugin setting field types

a39f4e3

Add Zod schemas for url and email field types to the plugin setting field discriminated union in manifest-schema.ts, to resolve issue emdash-cms#175.

github-actions bot added a commit that referenced this pull request Apr 3, 2026

@Sayeem3051 has signed the CLA in #189

7ad5e3d

Merge branch 'main' into patch-3

05c312a

github-actions bot added the needs-approval label Apr 5, 2026

Merge branch 'main' into patch-3

3258445

ascorbic reviewed Apr 11, 2026

View reviewed changes

Comment thread packages/core/src/plugins/manifest-schema.ts Outdated

Apply suggestion from @ascorbic

796575e

ascorbic reviewed Apr 11, 2026

View reviewed changes

Comment thread packages/core/src/plugins/types.ts Outdated

Apply suggestion from @ascorbic

343c2ea

ascorbic previously approved these changes Apr 11, 2026

View reviewed changes

github-actions bot added area/core size/S cla: signed labels Apr 11, 2026

ascorbic added the Awaiting author response label Apr 11, 2026

github-actions bot removed the needs-approval label Apr 11, 2026

Sayeem3051 and others added 3 commits April 12, 2026 17:42

style: format

2badf50

Merge branch 'main' into patch-3

cbbcd42

ascorbic requested a review from Copilot April 12, 2026 12:17

Copilot started reviewing on behalf of ascorbic April 12, 2026 12:17 View session

Copilot AI reviewed Apr 12, 2026

View reviewed changes

Sayeem3051 and others added 3 commits April 12, 2026 18:02

fix(types): correct typo SecretSettingFiel to SecretSettingField

83cef43

fix(manifest-schema): add default/placeholder to url/email Zod schemas

cd3cb15

Added optional default and placeholder fields to url and email types in manifest schema.

style: format

11e6a0f

test(manifest-schema): add tests for url/email setting field types

145b883

Added tests for url and email field types in admin.settingsSchema.

github-actions bot added size/M and removed size/S labels Apr 12, 2026

Sayeem3051 added 2 commits April 12, 2026 18:30

fix(manifest-schema.test): remove extra closing braces

3daa6bf

test: add number and file field tests for plugin manifest schema

566cd5d

github-actions bot added size/L overlap and removed size/M labels Apr 12, 2026

Sayeem3051 and others added 2 commits April 12, 2026 19:38

fix: add missing safeParse close in email field test

63d0d2b

Merge branch 'main' into patch-3

575714f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add url and email plugin setting field types (Issue #175)#189

Add url and email plugin setting field types (Issue #175)#189
Sayeem3051 wants to merge 17 commits intoemdash-cms:mainfrom
Sayeem3051:patch-3

Sayeem3051 commented Apr 3, 2026

Uh oh!

changeset-bot bot commented Apr 3, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 3, 2026 •

edited

Loading

Uh oh!

Sayeem3051 commented Apr 3, 2026

Uh oh!

Uh oh!

Uh oh!

ascorbic left a comment

Uh oh!

pkg-pr-new bot commented Apr 12, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions bot commented Apr 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		z.object({ ...baseSettingFields, type: z.literal("url") }),
		z.object({ ...baseSettingFields, type: z.literal("email") }),

Conversation

Sayeem3051 commented Apr 3, 2026

Type of change

Checklist

AI-generated code disclosure

Screenshots / test output

Uh oh!

changeset-bot bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sayeem3051 commented Apr 3, 2026

Uh oh!

Uh oh!

Uh oh!

ascorbic left a comment

Choose a reason for hiding this comment

Uh oh!

pkg-pr-new bot commented Apr 12, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

github-actions bot commented Apr 12, 2026

Overlapping PRs

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot bot commented Apr 3, 2026 •

edited

Loading

github-actions bot commented Apr 3, 2026 •

edited

Loading