#1602 Fix thread-safety of _llmInvocations and _history in AbstractAgentProcess#1620
Merged
igordayen merged 1 commit intoembabel:mainfrom Apr 20, 2026
Merged
Conversation
…tractAgentProcess Signed-off-by: Charles <azanux@gmail.com>
azanux
force-pushed
the
fix/thread-safe-ll-invocations-concurent
branch
from
85ceba6 to
730d381
Compare
igordayen
approved these changes
Apr 20, 2026
Contributor
igordayen
left a comment
igordayen
left a comment
There was a problem hiding this comment.
good catch. good to have it somehow captured in ThreadSafetyRulesTest.kt too,
| * consumer unconditionally resets → B is silently dropped. | ||
| */ | ||
| @Test | ||
| @Disabled("Outstanding race on _terminationRequest. Verified failure: expected <signal-B> but was <null>.") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#1602 , With
process-type=CONCURRENT, LLM calls run in parallel coroutines. Each call ends inAbstractAgentProcess._llmInvocations.add(...)viaToolLoopLlmOperations.recordUsage.Both
_llmInvocationsand_historywere backed byArrayList(viamutableListOf()), which is not thread-safe.Fix
Backed both fields with
CopyOnWriteArrayList:Test Plan
AbstractAgentProcessThreadSafetyTest— fails onArrayList, passes onCopyOnWriteArrayListSimple/Concurrent/CostAggregation/LlmInvocationHistory)Follow-up
A distinct race condition on
_terminationRequest(read-modify-write inDefaultToolLoop.checkForActionTerminationSignal) was discovered during this investigation.Not fixed here to keep the PR focused. Two
@Disabledtests (AbstractAgentProcessTerminationRaceTest) reproduce it deterministically - a tracking issue will be opened.