Status: update symbolic icons for gtk 4.22#1422
Merged
Merged
Conversation
Member
|
Hi @garaevdi, did you check https://github.com/elementary/iconbrowser? |
danirabbit
requested changes
May 6, 2026
| height='24'> | ||
| <path | ||
| id="path648" | ||
| class="error" |
Member
There was a problem hiding this comment.
It looks like all the style classes were removed. Can we keep these for compatibility with older GTK?
Contributor
Author
There was a problem hiding this comment.
Could you test it again? It seems like gtk 4.14 doesn't really know how to apply multiple style classes with single quotes. I naively assumed that if gtk3 can handle this, then it would be a piece of cake for gtk4.
Contributor
Author
Hi, I thought it was gtk4 since the beginning. Tested out last commit before the switch and it works fine, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second part of grand update of symbolic icons. Finally had some time to test out second biggest group of icons with gtk3 (Is there something like Icon Library but for gtk3?
gtk3-icon-browseronly shows some icons).Pretty much the same as #1421