Styles: Adjust and even-out padding for buttons and entry#980
Open
wpkelso wants to merge 6 commits into
Open
Conversation
danirabbit
reviewed
Apr 30, 2026
Comment on lines
+12
to
+13
| min-height: 24px; | ||
| min-width: 24px; |
Member
There was a problem hiding this comment.
I think these are min 16px because of icons. Probably don't want to touch the min size here and just change padding?
Member
Author
|
@danirabbit Yeah I forgot I use text scaling. It's properly aligned at 1x now, but because icons resize at thresholds and don't add any padding to compensate between icon and text size differences, image buttons linked or inline with a text button will be rectangular. Setting a minimum size of 16px for other types of buttons and such fixes the problem on the minimized end, but I'm not sure how to compensate on the magnified end.
(Looks like we might have some double border issue with the linked button borders 🙃 ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Might be a little contentious? I think the little bit of extra room on buttons gives a little better rhythm when types are mixed, but I tried not to turn them into balloons.
Before
After