Skip to content

Styles: Adjust and even-out padding for buttons and entry#980

Open
wpkelso wants to merge 6 commits into
mainfrom
wpkelso/adjust-button-padding
Open

Styles: Adjust and even-out padding for buttons and entry#980
wpkelso wants to merge 6 commits into
mainfrom
wpkelso/adjust-button-padding

Conversation

@wpkelso
Copy link
Copy Markdown
Member

@wpkelso wpkelso commented Apr 27, 2026

Might be a little contentious? I think the little bit of extra room on buttons gives a little better rhythm when types are mixed, but I tried not to turn them into balloons.

  • Squared up image buttons linked to entries
  • Evened out padding

Before

image image

After

image image

@wpkelso wpkelso requested a review from a team April 27, 2026 18:57
Copy link
Copy Markdown
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like something has gone wrong here. I'm guessing you're using some kind of text scaling? These don't match up with default text scaling on my end

Image

Comment thread lib/Styles/Gtk/Button.scss Outdated
Comment on lines +12 to +13
min-height: 24px;
min-width: 24px;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are min 16px because of icons. Probably don't want to touch the min size here and just change padding?

@wpkelso
Copy link
Copy Markdown
Member Author

wpkelso commented May 5, 2026

@danirabbit Yeah I forgot I use text scaling. It's properly aligned at 1x now, but because icons resize at thresholds and don't add any padding to compensate between icon and text size differences, image buttons linked or inline with a text button will be rectangular. Setting a minimum size of 16px for other types of buttons and such fixes the problem on the minimized end, but I'm not sure how to compensate on the magnified end.

Ex.
image

image image

(Looks like we might have some double border issue with the linked button borders 🙃 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants