Use different styles for overlay/non-overlay scrollbars#979
Merged
Conversation
danirabbit
requested changes
Apr 27, 2026
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
I like this direction a lot. Just a few comments.
Also for some reason backdrop styles have a double border?
Member
Author
|
I think I totally just goofed on what the inheritance structure was 😅 Kooha-2026-04-27-15-24-52.webm |
Co-authored-by: Danielle Foré <danielle@elementary.io>
danirabbit
approved these changes
May 6, 2026
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
These look really good. I think in a future branch I'd also like to see them have the "picked up" behavior like scale sliders, but this is great already. nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kooha-2026-04-27-14-37-16.webm