WindowManager/ShellClients: Explicitly override window group#2826
Merged
Conversation
lenemter
reviewed
Apr 30, 2026
Member
Author
|
@lenemter I've been thinking a bit more about it and maybe we should provide an enum of layers instead of allowing to provide any clutter.actor? What do you think about that? This would allow us to keep a bit more of an overview what layers exist and where goes what. |
44fc4ae to
753c0cb
Compare
Member
|
@leolost2605 I think it's a good idea to put different windows into different layers and an enum seems to be a good and intuitive solution, so that's a 👍 from me |
d8066d9 to
c345743
Compare
Member
Author
|
@lenemter all right I updated it and addressed the review comments so should be ready again :) |
lenemter
reviewed
May 2, 2026
c345743 to
2a380dc
Compare
Member
I still can reliable reproduce this issue, but I guess it's unrelated to this codepath |
lenemter
approved these changes
May 3, 2026
2956ab9 to
1761652
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To select the correct group for shell windows the window manager currently has to know what the possibilities are and then query the shell clients manager to see if the windows are one of that.
It also only works if we know the correct info about the windows before their window actor is turning visible.
Instead of this hacky solution we introduce a
override_window_groupin the wm. This is then called by the shellclientsmanager at that moment when it knows what the window will be.This has a few advantages: