WindowClone: display modal dialogs on top of parent window#2805
Conversation
leolost2605
left a comment
leolost2605
left a comment
There was a problem hiding this comment.
This looks really cool, thank you! Just a few comments :)
lenemter
force-pushed
the
lenemter/window-clone-children
branch
from
28270f3 to
751c32c
Compare
leolost2605
left a comment
leolost2605
left a comment
There was a problem hiding this comment.
Just a few more comments :)
lenemter
force-pushed
the
lenemter/window-clone-children
branch
from
af30519 to
000b949
Compare
leolost2605
left a comment
leolost2605
left a comment
There was a problem hiding this comment.
This looks really cool! I think you need to change the drag logic to hide the whole clone container and not just the clone though. Otherwise if you drag it looks like this:
lenemter
force-pushed
the
lenemter/window-clone-children
branch
from
9685f53 to
e0fec72
Compare
leolost2605
left a comment
leolost2605
left a comment
There was a problem hiding this comment.
Looks great and looks good to me :)
I think we should merge this after 8.5 was released though just to make sure we get some testing in daily since it is a pretty big and involved change and just to be sure we catch some glitches (e.g. moving a modal dialog to a new workspace via the gesture is a bit buggy but it's not great in main as well so I wouldn't treat it as blocking)
lenemter
force-pushed
the
lenemter/window-clone-children
branch
5 times, most recently
from
8996ce7 to
a98dfa2
Compare
lenemter
force-pushed
the
lenemter/window-clone-children
branch
from
a98dfa2 to
fd9e11a
Compare
2 participants
Closes #198
Before
After