fix(agents-server): sanitize attachment filename fallback#4548
Open
KyleAMathews wants to merge 3 commits into
Open
fix(agents-server): sanitize attachment filename fallback#4548KyleAMathews wants to merge 3 commits into
KyleAMathews wants to merge 3 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4548 +/- ##
===========================================
+ Coverage 54.80% 74.12% +19.31%
===========================================
Files 317 52 -265
Lines 36681 6895 -29786
Branches 10466 2189 -8277
===========================================
- Hits 20104 5111 -14993
+ Misses 16544 1768 -14776
+ Partials 33 16 -17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Content-Dispositionfilename fallback to ASCII-only before setting attachment response headersfilename*parameterTest plan
pnpm --filter @electric-ax/agents-runtime buildpnpm --dir packages/agents-server exec vitest run test/electric-agents-routes.test.ts