Develop 3.7.2#20
Merged
Merged
Conversation
- Remove `StackWalkerUtils.getCallHierarchy()` from `log.debug` calls in `BooleanUtils.java`, `NumberParseUtils.java`, and `DurationUtils.java` - Deprecate `StackWalkerUtils.java` as its functionality is no longer used in logging - Remove `@Slf4j` annotation from `BooleanUtils.java` where it's no longer needed - Add exception objects to `log.debug` calls within `catch` blocks for improved error context - Add `@Nullable` and `@NonNull` annotations to `EnvConfig.get()` for better nullability contract Signed-off-by: Egg-03 <111327101+eggy03@users.noreply.github.com>
- move classes from `commons.utils` to `utils` - move classes from `commons.constant` to `constant` Signed-off-by: Egg-03 <111327101+eggy03@users.noreply.github.com>
- Move command-related listener classes to the `command` package - Rename `DebugListener` to `DebugCommandListener` Signed-off-by: Egg-03 <111327101+eggy03@users.noreply.github.com>
- Inject `AuditLogRegistrationClient`, `MessageLogRegistrationClient`, and `MessageLogContentClient` into listener constructors
- Initialize API clients once in `Start.java` and pass them via `BootstrapService`
- Remove direct `EnvConfig.get("API_URL")` calls from listener classes
- Improve testability and reduce coupling by using dependency injection
- Refactor helper methods in `DebugCommandListener` to be non-static
Signed-off-by: Egg-03 <111327101+eggy03@users.noreply.github.com>
- Replace `@NotNull` with `@NonNull` across various listener and utility classes - Add `@Nullable` annotation to `channelId` and `ownerId` parameters in `GuildUtils.java` Signed-off-by: Egg-03 <111327101+eggy03@users.noreply.github.com>
- Make server stat command helper methods private - Adjust `getDataRequestingMember` signature to accept `Member` instead of the entire event Signed-off-by: Egg-03 <111327101+eggy03@users.noreply.github.com>
- The bot image was never a native-build. Only the API is native-built. Signed-off-by: Egg-03 <111327101+eggy03@users.noreply.github.com>
Signed-off-by: Egg-03 <111327101+eggy03@users.noreply.github.com>
- Replace `spring-boot-maven-plugin` with `maven-assembly-plugin` for packaging. - Configure `maven-assembly-plugin` to create a `jar-with-dependencies`. - Update `Dockerfile` to copy the new `papertrailbot-jar-with-dependencies.jar`. Signed-off-by: Egg-03 <111327101+eggy03@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains internal refactors for easier maintainability
[2b3e928] build: switch to maven-assembly-plugin
[a85e2b7] chore: bump version to 3.7.2
[330555a] docs: remove native image description
[4815c89] refactor(server-stat-command): make helpers private
[8b71496] style(annotations): replace
@NotNullwith@NonNullannotations[589391f] refactor(clients): inject api clients into listeners
[4dcf4c3] refactor(listeners): reorganize command listener packages
[7a5c7bf] refactor: unpack commons package
[8906340] refactor(utils): remove
StackWalkerUtilsfrom logging and deprecate