Skip to content

Native Problog#1

Draft
subtleGradient wants to merge 33 commits intomainfrom
native-datalog
Draft

Native Problog#1
subtleGradient wants to merge 33 commits intomainfrom
native-datalog

Conversation

@subtleGradient
Copy link
Copy Markdown
Member

No description provided.

This adds seeded stochastic inference metadata and grounded non-ground query projection so ProbLog parity tests can verify observable backend behavior.
Add oxlint as a devDependency and add "lint" and "lint-fix" npm scripts.
Update package-lock with oxlint and its platform bindings.
Remove nullish-coalescing fallbacks when spreading input.evidence and
options.prologOptions (adjusts merge behavior). Reformat tests for
linting.
Use nullish coalescing to default undefined query counts and
probabilities to 0 during accumulation and normalization. Add
explicit test checks to fail fast if a sampling or exact
probability is undefined.
Copilot AI review requested due to automatic review settings April 9, 2026 15:10
@subtleGradient subtleGradient marked this pull request as draft April 9, 2026 15:12
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds an offline-friendly ProbLog “native” development surface by introducing a deterministic local fixture-corpus stub, a runnable ProbLog examples script, and updated documentation/task tracking to support parity workflows while the authoritative corpus strategy remains undecided.

Changes:

  • Add a deterministic, local ProbLog fixture-corpus stub (107 top-level .pl files + representative parity fixtures) with documentation.
  • Add examples/problog-examples.ts to run fixture-aligned ProbLog examples plus exported validators for example definitions/evolution.
  • Update root and examples READMEs, and add task/trace artifacts related to Bun parity + offline execution (plus a .tmp/problog subproject pointer).

Reviewed changes

Copilot reviewed 288 out of 329 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
fixtures/problog-corpus-stub/problog-test/01_inconsistent.pl Adds representative inconsistent-evidence fixture stub.
fixtures/problog-corpus-stub/problog-test/4_bayesian_net.pl Adds representative Bayesian-network-style fixture stub.
fixtures/problog-corpus-stub/problog-test/ad_fact.pl Adds representative annotated-disjunction fixture stub.
fixtures/problog-corpus-stub/problog-test/non_ground_query.pl Adds representative non-ground query fixture stub.
fixtures/problog-corpus-stub/problog-test/stub_005.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_006.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_007.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_008.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_009.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_010.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_011.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_012.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_013.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_014.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_015.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_016.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_017.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_018.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_019.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_020.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_021.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_022.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_023.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_024.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_025.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_026.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_027.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_028.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_029.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_030.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_031.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_032.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_033.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_034.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_035.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_036.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_037.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_038.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_039.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_040.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_041.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_042.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_043.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_044.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_045.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_046.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_047.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_048.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_049.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_050.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_051.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_052.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_053.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_054.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_055.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_056.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_057.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_058.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_059.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_060.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_061.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_062.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_063.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_064.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_065.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_066.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_067.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_068.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_069.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_070.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_071.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_072.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_073.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_074.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_075.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_076.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_077.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_078.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_079.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_080.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_081.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_082.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_083.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_084.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_085.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_086.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_087.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_088.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_089.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_090.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_091.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_092.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_093.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_094.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_095.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_096.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_097.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_098.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_099.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_100.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_101.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_102.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_103.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_104.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_105.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_106.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/problog-test/stub_107.pl Adds placeholder fixture stub query.
fixtures/problog-corpus-stub/README.md Documents the offline stub corpus shape and intent.
examples/problog-examples.ts Adds runnable ProbLog examples and exported validation helpers.
examples/README.md Documents the new ProbLog examples runner.
README.md Adds ProbLog quick start and updates dev commands + example listings.
.tmp/problog Adds a subproject commit pointer for ProbLog corpus.
.opencode Adds local absolute path pointer.
.tasks/task-m-wire-root-bun-parity-reporting-20260408.md Task tracking for Bun parity reporting and offline flow.
.tasks/task-m-repoint-parity-to-authoritative-corpus-20260408.md Task tracking for repointing parity to authoritative corpus.
.tasks/task-m-make-example-evolution-suite-green-20260408.md Task tracking for evolution suite status.
.tasks/task-m-implement-example-evolution-validation-20260408.md Task tracking for evolution validation implementation.
.tasks/task-m-decide-error-example-expectation-policy-20260408.md Task tracking for error-example expectations policy.
.tasks/task-m-build-full-107-fixture-registry-20260408.md Task tracking for fixture registry.
.tasks/task-m-audit-generic-problog-runtime-failures-20260408.md Task tracking for audit findings.
.tasks/task-m-align-example-spec-schema-and-tests-20260408.md Task tracking for spec/schema/test alignment.
.tasks/task-m-add-explicit-invalid-model-errors-20260408.md Task tracking for invalid-model error work.
.tasks/task-l-wire-full-parity-into-root-bun-test-20260408.md Task tracking for wiring parity into Bun test.
.tasks/task-l-update-example-tests-per-policy-20260408.md Task tracking for updating tests per policy.
.tasks/task-l-update-example-schema-per-policy-20260408.md Task tracking for updating schema per policy.
.tasks/task-l-run-evolution-policy-suite-under-bun-20260408.md Task tracking for Bun evolution-policy run.
.tasks/task-l-require-rationale-for-expectation-changes-20260408.md Task tracking for rationale enforcement.
.tasks/task-l-prove-root-bun-parity-determinism-20260408.md Task tracking for determinism.
.tasks/task-l-point-parity-tooling-at-real-corpus-20260408.md Task tracking for pointing tooling at real corpus.
.tasks/task-l-enforce-drift-and-coverage-failure-20260408.md Task tracking for drift/coverage enforcement.
.tasks/task-l-decide-authoritative-fixture-corpus-strategy-20260408.md Task tracking for corpus strategy decision.
.tasks/task-l-confirm-error-example-policy-with-user-20260408.md Task tracking for policy confirmation.
.tasks/task-l-catalog-invalid-model-failure-shapes-20260408.md Task tracking for failure-shape catalog.
.tasks/task-l-build-local-offline-fixture-corpus-stub-20260408.md Task tracking for stub corpus build.
.tasks/task-l-author-bijective-107-fixture-registry-20260408.md Task tracking for bijective registry.
.tasks/task-l-add-typed-invalid-model-error-cases-20260408.md Task tracking for typed invalid-model errors.
.tasks/task-l-add-stable-id-drift-detection-20260408.md Task tracking for stable id drift detection.
.tasks/task-l-add-regression-tests-for-explicit-invalid-model-errors-20260408.md Task tracking for regressions.
.tasks/task-h-real-corpus-bun-parity-20260408.md Umbrella task tracking for real-corpus parity.
.tasks/task-h-invalid-model-error-taxonomy-20260408.md Umbrella task tracking for error taxonomy.
.tasks/task-h-example-evolution-guardrails-20260408.md Umbrella task tracking for evolution guardrails.
.tasks/task-h-example-contract-clarification-20260408.md Umbrella task tracking for contract clarification.
.tasks/blocked-by-user/needs-attention-2026-04-08.md Consolidates human blockers for corpus + policy decisions.
.tasks/blocked-by-user/needs-attention-2026-02-27.md Earlier human-blocker consolidation record.
.tasks/artifacts/gaps-snapshot-20260408135043.md Adds internal gap snapshot artifact.
.tasks/artifacts/gaps-snapshot-20260227203012.md Adds internal gap snapshot artifact.
.tasks/artifacts/gaps-snapshot-20260227195755.md Adds internal gap snapshot artifact.
.tasks/artifacts/gaps-snapshot-20260227181708.md Adds internal gap snapshot artifact.
.tasks/artifacts/gaps-snapshot-20260227174013.md Adds internal gap snapshot artifact.
.tasks/artifacts/gaps-snapshot-20260227171819.md Adds internal gap snapshot artifact.
.tasks/artifacts/gaps-snapshot-20260227164111.md Adds internal gap snapshot artifact.
.tasks/archive/20260408-reconciliation-reset/task-m-wire-root-bun-parity-invocation.md Archives prior task record.
.tasks/archive/20260408-reconciliation-reset/task-m-port-top-level-fixtures-to-bun-parity-tests.md Archives prior task record.
.tasks/archive/20260408-reconciliation-reset/task-m-make-bun-test-green.md Archives prior task record.
.tasks/archive/20260408-reconciliation-reset/task-m-fixture-corpus-provisioning-strategy.md Archives prior task record.
.tasks/archive/20260408-reconciliation-reset/task-m-enforce-example-schema-and-validation.md Archives prior task record.
.tasks/archive/20260408-reconciliation-reset/task-m-enforce-example-expected-probability-contract.md Archives prior task record.
.tasks/archive/20260408-reconciliation-reset/task-m-build-fixture-registry-and-drift-check.md Archives prior task record.
.tasks/archive/20260408-reconciliation-reset/task-m-add-examples-suite-automation.md Archives prior task record.
.tasks/archive/20260408-reconciliation-reset/task-m-add-example-evolution-guardrails.md Archives prior task record.
.tasks/archive/20260408-reconciliation-reset/task-l-wire-problog-examples-into-automated-offline-suite.md Archives prior task record.
.tasks/archive/20260408-reconciliation-reset/task-l-require-probability-expectations-for-non-error-examples.md Archives prior task record.
.tasks/archive/20260408-reconciliation-reset/task-l-prove-bun-parity-determinism-over-repeated-runs.md Archives prior task record.
.tasks/archive/20260408-reconciliation-reset/task-l-port-priority-problog-fixtures-to-bun-tests.md Archives prior task record.
.tasks/archive/20260408-reconciliation-reset/task-l-implement-examples-runner-order-and-completeness-assertions.md Archives prior task record.
.tasks/archive/20260408-reconciliation-reset/task-l-fix-bun-rejects-in-runtime-behavior-tests.md Archives prior task record.
.tasks/archive/20260408-reconciliation-reset/task-l-fix-bun-rejects-in-knowledge-base-tests.md Archives prior task record.
.tasks/archive/20260408-reconciliation-reset/task-l-define-example-schema-with-id-intent-program-expectations.md Archives prior task record.
.tasks/archive/20260408-reconciliation-reset/probe-write.md Archives prior probe artifact.
.tasks/archive/20260227-reconciliation-reset/task-m-wire-root-bun-test-path-and-determinism.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-wire-root-bun-parity-invocation.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-run-mono-regression-validation.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-run-mono-regression-validation-20260227181708.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-regression-and-compat-validation.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-public-problog-runtime-api.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-port-top-level-fixtures-to-bun-tests.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-port-107-top-level-fixtures-to-bun-parity-tests.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-parser-and-ast-problog-surface.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-implement-sampling-backend-path.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-implement-sampling-backend-path-20260227181708.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-implement-nonground-query-probability-enumeration.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-implement-nonground-query-probability-enumeration-20260227181708.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-grounding-and-choice-model.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-fix-tool-ai-runtime-dependency.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-fix-tool-ai-runtime-dependency-20260227181708.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-exact-and-sampling-evaluators.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-enforce-example-schema-and-validation.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-enforce-example-expected-probability-contract.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-design-problog-examples-schema-and-validator.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-decide-nonground-query-contract.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-decide-nonground-query-contract-20260227181708.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-conformance-fixture-port.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-complete-example-portfolio-coverage.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-build-fixture-registry-and-drift-fail.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-build-bun-parity-registry-and-drift-check.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-author-problog-example-portfolio.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-add-sampling-backend-validation.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-add-sampling-backend-validation-20260227181708.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-add-examples-suite-automation.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-add-examples-runner-and-automation.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-m-add-example-evolution-guardrails.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-wire-problog-results-and-error-types.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-wire-problog-examples-into-automated-offline-suite.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-wire-examples-suite-into-offline-automation.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-validate-nonground-query-fixture-non_ground_query.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-validate-nonground-query-fixture-non_ground_query-20260227181708.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-run-tool-vitest-after-dependency-fix.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-run-tool-vitest-after-dependency-fix-20260227181708.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-run-root-and-tool-regression-suite.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-run-root-and-tool-regression-suite-20260227181708.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-run-deterministic-regression-suite.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-require-probability-expectations-for-non-error-examples.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-prove-bun-parity-determinism-repeated-run.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-prove-bun-parity-determinism-over-repeated-runs.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-port-priority-problog-fixtures-to-bun-tests.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-port-priority-fixtures-into-bun-parity-tests.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-port-core-problog-fixtures-and-expected-values.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-implement-randomized-world-sampling-estimator.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-implement-randomized-world-sampling-estimator-20260227181708.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-implement-nonground-query-ground-instance-projection.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-implement-nonground-query-ground-instance-projection-20260227181708.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-implement-grounding-nonground-choice-detection.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-implement-examples-runner-order-and-tolerance-assertions.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-implement-ad-mutual-exclusion-and-null-choice.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-design-problog-runtime-surface.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-add-root-bun-parity-command.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-add-problog-tokens-and-directives.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-add-nonground-query-conformance-specs.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-add-nonground-query-conformance-specs-20260227181708.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-add-inconsistent-evidence-and-nonground-failure-specs.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-add-exact-vs-sampling-agreement-tests.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-add-exact-vs-sampling-agreement-tests-20260227181708.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-add-cross-backend-agreement-specs.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-add-annotated-disjunction-ast-and-lowering.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-add-ai-package-to-tool-and-lockfile.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-l-add-ai-package-to-tool-and-lockfile-20260227181708.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-h-problog-semantics-and-inference.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-h-problog-sampling-backend.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-h-problog-sampling-backend-20260227181708.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-h-problog-nonground-query-parity.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-h-problog-nonground-query-parity-20260227181708.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-h-problog-language-and-api.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-h-problog-conformance-and-compat.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-h-problog-compatibility-guardrail.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-h-problog-compatibility-guardrail-20260227181708.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-h-problog-bun-parity-suite.md Archives prior task record.
.tasks/archive/20260227-reconciliation-reset/task-h-problog-bun-parity-suite-20260227203012.md Archives prior task record.
.ok/problog2.ok.md Adds ProbLog2 “ideal target state” documentation.
.ok/problog-examples.ok.md Adds examples “ideal target state” documentation.
.ok/problog-bun-test-parity.ok.md Adds Bun parity “ideal target state” documentation.
Comments suppressed due to low confidence (1)

.tmp/problog:1

  • This looks like a Git submodule entry, but the PR doesn’t include a corresponding .gitmodules change. Without .gitmodules, checkouts/clones won’t know how to initialize the submodule, and tooling that expects .tmp/problog/test to exist may fail. Add/update .gitmodules (and ensure the submodule URL/path are correct), or avoid committing the submodule pointer if the intent is to keep .tmp/ as a local/untracked cache.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +475 to +479
for (const example of EXAMPLES) {
await runExample(example);
}

console.log(`Completed ${EXAMPLES.length} ProbLog examples.`);
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module has top-level side effects (it executes the examples immediately). If any tests or other code import the exported helpers (e.g., validateProbLogExampleDefinitions / validateProbLogExampleEvolution), those imports will also run all examples, which can make test runs flaky/slow and can fail in environments without the expected fixture files. Fix by moving the exported validation helpers (and any shared types) into a side-effect-free module, and keep problog-examples.ts as a runnable entrypoint only; alternatively, guard execution behind an entrypoint check (e.g., import.meta.main for Bun) so imports don’t execute the runner.

Suggested change
for (const example of EXAMPLES) {
await runExample(example);
}
console.log(`Completed ${EXAMPLES.length} ProbLog examples.`);
if (import.meta.main) {
for (const example of EXAMPLES) {
await runExample(example);
}
console.log(`Completed ${EXAMPLES.length} ProbLog examples.`);
}

Copilot uses AI. Check for mistakes.
readonly tolerance: number;
readonly expected: readonly ProbabilityExpectation[];
readonly expectedError?: ProbLogErrorCode;
readonly query?: readonly string[];
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ProbLogExample defines query as optional, but the definition validator later rejects examples without query (requires a non-empty array). That’s an internal contract mismatch: either make query required in the type and populate it everywhere, or update the validator to allow omitted query (e.g., treating it as "use queries declared in the program") so the type and validation rules agree.

Suggested change
readonly query?: readonly string[];
readonly query: readonly string[];

Copilot uses AI. Check for mistakes.
Comment thread .opencode
@@ -0,0 +1 @@
/Users/tom/Work/work/.opencode No newline at end of file
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file embeds an absolute local filesystem path, which is machine/user-specific and may leak developer workstation details into the repo. Consider removing it from version control and adding it to .gitignore, or replacing it with a repo-relative path/config that is portable across environments.

Suggested change
/Users/tom/Work/work/.opencode
.opencode

Copilot uses AI. Check for mistakes.
This directory provides a deterministic, local fixture-corpus stub for parity development workflows.

- Stub corpus root: `fixtures/problog-corpus-stub/problog-test`
- Top-level fixture files: `107`
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is ambiguous (it reads like a filename). Consider clarifying to something like "Top-level fixture file count: 107" to avoid confusion about what 107 refers to.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants