Containerised distribution of Guardian main branch#11
Draft
tonytw1 wants to merge 77 commits into
Draft
Conversation
tonytw1
force-pushed
the
containerised
branch
2 times, most recently
from
b0942e9 to
887a0ca
Compare
tonytw1
force-pushed
the
containerised
branch
2 times, most recently
from
5b3abf6 to
5df2f75
Compare
tonytw1
force-pushed
the
containerised
branch
6 times, most recently
from
db06496 to
8f64bac
Compare
tonytw1
force-pushed
the
containerised
branch
7 times, most recently
from
e8ad009 to
3ce864b
Compare
tonytw1
force-pushed
the
containerised
branch
3 times, most recently
from
4810e23 to
779c5c4
Compare
tonytw1
force-pushed
the
containerised
branch
from
779c5c4 to
a3135c0
Compare
tonytw1
force-pushed
the
containerised
branch
from
a3135c0 to
5eb0f1f
Compare
tonytw1
force-pushed
the
containerised
branch
from
5eb0f1f to
d8ede2b
Compare
tonytw1
force-pushed
the
containerised
branch
from
d8ede2b to
28d90ef
Compare
tonytw1
force-pushed
the
containerised
branch
from
28d90ef to
0ca45e2
Compare
tonytw1
force-pushed
the
containerised
branch
from
0ca45e2 to
e4dbaad
Compare
…its.UsageRights not always been available on the JSON edits record. Editing the metadata of an image with no usage rights overrides seems to remove the field, causing getUsageRights to start HTTP 500 erroring.
matchUsageGroup using hashKeyName placeholder to avoid grouping reserved keyword.
Guava is an undeclared transitive dependency used directly in source code. 2 files use Guava APIs directly: 1. common-lib/src/main/java/com/gu/mediaservice/DeprecatedHashWrapper.java:3 — imports com.google.common.hash.HashFunction / Hashing 2. image-loader/app/lib/Downloader.scala:6 — imports com.google.common.hash.HashingOutputStream and com.google.common.io.ByteStreams But Guava is never explicitly declared in build.sbt. It only arrives transitively — almost certainly from aws-java-sdk-* (v1).
This reverts commit b38e20c
…like owned photographs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Produces container images for a generalised Grid install based on the Guardian's
mainbranch.Reasonably opinionated towards "we use AWS services but we don't necessarily run the application on AWS".
How should a reviewer test this change?
How can success be measured?
Who should look at this?
Tested? Documented?