feat(ampup): add token resolution chain and --jobs CLI flag#1777
Closed
feat(ampup): add token resolution chain and --jobs CLI flag#1777
Conversation
Add GitHub token resolution with fallback chain (explicit → gh auth token → unauthenticated) and --jobs/-j flag for controlling concurrent downloads in preparation for the download manager.
Contributor
|
@mitchhs12 This PR belongs to the Ampup repo |
Rename token tests to follow <function>_<scenario>_<outcome> convention, add Given-When-Then structure, and document that --github-token values may be visible in process listings.
…ic (#1762) Add GitHubRateLimiter that parses X-RateLimit-Remaining, X-RateLimit-Reset, and Retry-After headers. On 429 or rate-limit 403, sets a global pause shared across all concurrent downloads and retries once. Preemptively pauses when remaining hits 0. Integrates into GitHubClient via send_with_rate_limit, which wraps all HTTP methods with rate-limit awareness.
Contributor
Author
|
Closing as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gh auth token→ unauthenticated--jobs/-jCLI flag toinstallandupdatecommands for controlling concurrent downloads (default: 4)