Skip to content

Fix determin BankingInformation throught TOP_Kante Path#2327

Merged
mariusheine merged 4 commits intomainfrom
fisx-banking-line
Apr 22, 2026
Merged

Fix determin BankingInformation throught TOP_Kante Path#2327
mariusheine merged 4 commits intomainfrom
fisx-banking-line

Conversation

@TruongQuangSB
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 13, 2026

Test Results

133 tests  ±0   133 ✅ ±0   57s ⏱️ +15s
 33 suites ±0     0 💤 ±0 
 33 files   ±0     0 ❌ ±0 

Results for commit c9e1004. ± Comparison against base commit 56705b0.

This pull request removes 11 and adds 11 tests. Note that renamed tests count towards both.
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[1] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@74170687
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[2] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@1e9469b8
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[3] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@5f254608
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[4] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@1b1c538d
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[5] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@6325f352
org.eclipse.set.feature.plazmodel.test.CalculateTopologicalCoordinateTest ‑ testTopologischeCoordinateCalculate(Pair)[1] Pair [first=pphn, second=/tmp/set-test2438544240536361880PPHN_1.10.0.3_01-02_Ibn-Z._-_2._AeM_2022-05-17_13-44_tg3.planpro]
org.eclipse.set.feature.siteplan.transform.SiteplanTransformatorTest ‑ testSiteplanTransformSuccessful(String)[1] /tmp/set-test3113491628536481439PPHN_1.10.0.3_01-02_Ibn-Z._-_2._AeM_2022-05-17_13-44_tg3.planpro
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[1] TestData [input=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@254513e8, expected=multi/container-id/1539392017/element-id]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[2] TestData [input=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@74f89bad, expected=multi/456/1563321789/123]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[1] TestData [input=Pair [first=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@390a07a0, second=other], expected=multi/container-id/220371218/element-id/other=other]
…
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[1] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@ec8f4b9
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[2] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@1457fde
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[3] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@2630dbc4
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[4] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@5a1c3cb4
org.eclipse.set.basis.graph.DigraphsTest ‑ testGetPathsDigraphPP(TestGetPathsDigraphPP)[5] org.eclipse.set.basis.graph.DigraphsTest$TestGetPathsDigraphPP@56637cff
org.eclipse.set.feature.plazmodel.test.CalculateTopologicalCoordinateTest ‑ testTopologischeCoordinateCalculate(Pair)[1] Pair [first=pphn, second=/tmp/set-test17546975021983276472PPHN_1.10.0.3_01-02_Ibn-Z._-_2._AeM_2022-05-17_13-44_tg3.planpro]
org.eclipse.set.feature.siteplan.transform.SiteplanTransformatorTest ‑ testSiteplanTransformSuccessful(String)[1] /tmp/set-test16877465223214832542PPHN_1.10.0.3_01-02_Ibn-Z._-_2._AeM_2022-05-17_13-44_tg3.planpro
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[1] TestData [input=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@20155dae, expected=multi/container-id/701279123/element-id]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKey(TestData)[2] TestData [input=org.eclipse.set.model.planpro.Signale.impl.SignalImpl@417bfebd, expected=multi/456/616080275/123]
org.eclipse.set.ppmodel.extensions.utils.CacheUtilsTest ‑ testGetCacheKeyOther(TestData)[1] TestData [input=Pair [first=org.eclipse.set.model.planpro.Weichen_und_Gleissperren.impl.W_Kr_Gsp_ElementImpl@6f80cf5, second=other], expected=multi/container-id/715194034/element-id/other=other]
…

♻️ This comment has been updated with latest results.

@mariusheine
Copy link
Copy Markdown
Contributor

@TruongQuangSB What do you to see the plaz_model changes in #2328 ? Looks like all banking line issues are resolved now with this bugfix. Is that correct from your point of view?

@TruongQuangSB
Copy link
Copy Markdown
Contributor Author

@mariusheine yes, all was resolved by this change. The IDTopKantePath no need inclusive start and end TOP_Kanten

@mariusheine mariusheine merged commit 6281c20 into main Apr 22, 2026
15 checks passed
@mariusheine mariusheine deleted the fisx-banking-line branch April 22, 2026 05:38
TruongQuangSB added a commit to SuB-PlanPro/set that referenced this pull request Apr 24, 2026
…2327)

* Fix determin BankingInformation throught TOP_Kante Path

* Add NPE Check

* Update table reference

---------

Co-authored-by: eclipse-set-bot <set-bot@eclipse.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants